From: Cong Wang <xiyou.wangcong@gmail.com>
To: edumazet@google.com
Cc: cong.wang@bytedance.com, davem@davemloft.net, dsahern@kernel.org,
kuba@kernel.org, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, pabeni@redhat.com,
peilin.ye@bytedance.com, yepeilin.cs@gmail.com,
yoshfuji@linux-ipv6.org
Subject: Re: [PATCH net-next] net/sock: Introduce trace_sk_data_ready()
Date: Sat, 15 Oct 2022 13:07:29 -0700 [thread overview]
Message-ID: <634b1304.c80a0220.cedc6.e007@mx.google.com> (raw)
In-Reply-To: <20220928221514.27350-1-yepeilin.cs@gmail.com>
On Thu, Sep 29, 2022 at 09:19:34AM -0700, Eric Dumazet wrote:
> Second patch adding the tracing point once in the helper ?
>
> Alternatively, why not add the tracepoint directly in the called
> functions (we have few of them),
> instead of all call points ?
Why do we want to give implementations of sk_data_ready() freedom
to not to call this trace_sk_data_ready()?
Thanks.
next prev parent reply other threads:[~2022-10-15 20:07 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-28 22:15 [PATCH net-next] net/sock: Introduce trace_sk_data_ready() Peilin Ye
2022-09-29 16:18 ` Jakub Kicinski
2022-10-05 0:06 ` Peilin Ye
2022-09-29 16:19 ` Eric Dumazet
2022-10-05 0:14 ` Peilin Ye
2022-10-07 22:10 ` [PATCH net-next v2] " Peilin Ye
2022-10-08 0:38 ` kernel test robot
2022-10-08 1:11 ` Peilin Ye
2022-10-08 0:48 ` kernel test robot
2022-10-11 19:58 ` [PATCH net-next v3] " Peilin Ye
2022-10-12 5:58 ` Leon Romanovsky
2022-10-12 17:57 ` Peilin Ye
2022-10-12 23:21 ` [PATCH net-next v4] " Peilin Ye
2022-10-13 9:43 ` Leon Romanovsky
2022-10-13 23:58 ` Peilin Ye
2022-10-14 0:00 ` [PATCH net-next v5] " Peilin Ye
2022-10-14 6:35 ` Leon Romanovsky
2022-11-10 2:28 ` Peilin Ye
2022-10-15 20:07 ` Cong Wang [this message]
2022-10-15 20:26 ` [PATCH net-next] " Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=634b1304.c80a0220.cedc6.e007@mx.google.com \
--to=xiyou.wangcong@gmail.com \
--cc=cong.wang@bytedance.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=peilin.ye@bytedance.com \
--cc=yepeilin.cs@gmail.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox