From: Chris Mason <mason@suse.com>
To: Alexander Viro <viro@math.psu.edu>, David <david@blue-labs.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [OOPS] report
Date: Fri, 16 Mar 2001 00:29:34 -0500 [thread overview]
Message-ID: <635010000.984720574@tiny> (raw)
In-Reply-To: <Pine.GSO.4.21.0103152131230.10709-100000@weyl.math.psu.edu>
On Thursday, March 15, 2001 09:44:48 PM -0500 Alexander Viro
<viro@math.psu.edu> wrote:
>
>
> On Thu, 15 Mar 2001, David wrote:
>
>> 2.4.2-ac4
>>
>> Mar 15 18:02:49 Huntington-Beach kernel: end_request: I/O error, dev
>> 16:41 (hdd), sector 9512
>> Mar 15 18:02:49 Huntington-Beach kernel: hdd: drive not ready for command
>> Mar 15 18:02:48 Huntington-Beach kernel: hdd: drive not ready for command
>> Mar 15 18:02:49 Huntington-Beach kernel: hdd: status error: status=0x00
>> { } Mar 15 18:02:49 Huntington-Beach kernel: hdd: drive not ready for
>> command Mar 15 18:02:49 Huntington-Beach kernel: journal-601, buffer
>> write failed Mar 15 18:02:49 Huntington-Beach kernel: kernel BUG at
>> prints.c:332!
>
> Umm... Chris, I really don't think that panic() (or BUG(), for that
> matter) is an appropriate reaction to IO errors. They are expected
> events, after all...
>
Nods. It needs to force a readonly mount instead.
> ObReiserfs_panic: what the hell is that ->s_lock bit about? panic()
> _never_ tries to do any block IO. It looks like a rudiment of something
> that hadn't been there for 5 years, if not longer. The same goes for
> ext2_panic() and ufs_panic(), BTW... I would suggest crapectomey here.
Ugh, that should have been dragged out and shot...patch will come in the AM.
-chris
next prev parent reply other threads:[~2001-03-16 5:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-03-16 2:07 [OOPS] report David
2001-03-16 2:44 ` Alexander Viro
2001-03-16 5:29 ` Chris Mason [this message]
2001-03-16 5:32 ` Alexander Viro
2001-03-16 5:51 ` Chris Mason
2001-03-16 6:03 ` Alexander Viro
2001-03-16 6:27 ` Chris Mason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=635010000.984720574@tiny \
--to=mason@suse.com \
--cc=david@blue-labs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@math.psu.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox