From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1424444AbcFMOYf (ORCPT <rfc822;w@1wt.eu>);
	Mon, 13 Jun 2016 10:24:35 -0400
Received: from mout.kundenserver.de ([212.227.126.134]:64379 "EHLO
	mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1424006AbcFMOYd (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 13 Jun 2016 10:24:33 -0400
From: Arnd Bergmann <arnd@arndb.de>
To: Binoy Jayan <binoy.jayan@linaro.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Johnny Kim <johnny.kim@atmel.com>, Austin Shin <austin.shin@atmel.com>,
        Chris Park <chris.park@atmel.com>, Tony Cho <tony.cho@atmel.com>,
        Glen Lee <glen.lee@atmel.com>, Leo Kim <leo.kim@atmel.com>,
        devel@driverdev.osuosl.org, linux-wireless@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/7] staging: wilc1000: Replace semaphore cfg_event with completion
Date: Mon, 13 Jun 2016 15:25:03 +0200
Message-ID: <6370742.CzW4YYN43W@wuerfel>
User-Agent: KMail/5.1.3 (Linux/4.4.0-22-generic; KDE/5.18.0; x86_64; ; )
In-Reply-To: <1465814259-3009-4-git-send-email-binoy.jayan@linaro.org>
References: <1465814259-3009-1-git-send-email-binoy.jayan@linaro.org> <1465814259-3009-4-git-send-email-binoy.jayan@linaro.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-Provags-ID: V03:K0:Y/bqKS5zaHvnVr0RPKzV3d6ecXe9valqFIPj4eZC4aH/gSW3RA3
 EVvBGx0eIFx32CgpJnZEyjNvh31qNKSN6MecQslV9b1yS7yZCaoTeJ/qQovFjAs0WRkB4YG
 fAM+yXNJQ3EwTldqXIOdDemBrf2NjTDvrKkTr26TpuHHwt8CPU9G7NpEL+gApNI/tZnBFl5
 Sve10pOR4/p1204BwO5Hg==
X-UI-Out-Filterresults: notjunk:1;V01:K0:9887QrExxpg=:M08e/wG6RLf8NCnzLvBdv1
 VwPnSUI7JuJUHB2lDXWiU3UwmU6i7eBu7B4nOLpXBm84RPioVboKVSsCXJQXSGZPb1v6OY9KS
 y4nzLQPQ5bEfHVgT69SrxF2Z05bonWt9QiCZdniJRm9F3HrnWJGx/y3VC4M2H2h3T5FkKrvro
 G+XJar4N9IkhIpcPll5b4RuATL3ZE1Ckcb11Zzajay8BcI4D2N0s8ZCS+64jXzquep40Nz3Pu
 UxeF0/toRH+gtsspAwOhwJEyDIoko56QsMeJWL96omJ9Kcm+D6+XSZn0gwyJh58u0UQLF86IR
 QlNgxMWYs/++LvWcTXQbGw2PUzub4D0eEnDdoAhHd2mtZTmeGWRMhvVxMPVBPnXHMimz0at3v
 K/1WLFr7Qo5YllgFmy84MfyaDqrzPcTZiAgnvYXtBrgeJQPOSw7s2+klmAVnusa7MIQ59rMNp
 mQlgXiHseeeh1jdEq2KQVhPyteeUC0fPFjwsKJ/VsA35LUwHYC9aYOJBJPpw2qbRP/Lnkivvd
 dvS/Lb/UA0x9SKzrftbbavsY2m1CXl0MB0aQ8fwR/sZjcDfQENwr0iQAT++vLqwnep1D//fNY
 fN1RbGB4wcN/YHijIc0jDGHoU0Yg2aRzQy1PTJvsFJYqzQVH6VtyX9x9yLTACakCG5HxBNKxw
 5oXNhiz4e7RAasDsLuH1kpCP2NTvpD8A1+cTiReybsBcxP4YduIFOXTDczCxI8xzXqvwH7Tlo
 rSGuij+5YwKxiJQW
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Monday, June 13, 2016 4:07:35 PM CEST Binoy Jayan wrote:
> The semaphore 'cfg_event' is used as completion, so convert
> it to a struct completion type.
> 
> Signed-off-by: Binoy Jayan <binoy.jayan@linaro.org>

The change looks good, but


>                         netdev_dbg(vif->ndev, "Set Timed Out\n");
>                         ret_size = 0;
>                 }
> +
>                 wilc->cfg_frame_in_use = 0;
>                 wilc->cfg_frame_offset = 0;
>                 wilc->cfg_seq_no += 1;
> @@ -1246,6 +1247,7 @@ int wilc_wlan_cfg_get(struct wilc_vif *vif, int start, u16 wid, int commit,
>  {
>         u32 offset;
>         int ret_size;
> +
>         struct wilc *wilc = vif->wilc;
>  
>         if (wilc->cfg_frame_in_use)
> 

These two extra newlines seem unrelated to the other changes and probably
slipped in by accident. The first one is actually ok according to
normal coding style, while the second one looks misplaced.

In general, it's better not to touch whitespace when doing other changes,
except when you are fixing the same code you modify anyway.

	Arnd