From: Daniel Beer <daniel.beer@igorinstitute.com>
To: alsa-devel@alsa-project.org
Cc: linux-kernel@vger.kernel.org,
Daniel Beer <daniel.beer@igorinstitute.com>,
Andy Liu <andy-liu@ti.com>, Mark Brown <broonie@kernel.org>,
Derek Simkowiak <derek.simkowiak@igorinstitute.com>
Subject: [PATCH 2/2] ASoC: tas5805m: add missing page switch.
Date: Thu, 27 Oct 2022 21:38:38 +1300 [thread overview]
Message-ID: <638311c7.a70a0220.4e021.3abe@mx.google.com> (raw)
In tas5805m_refresh, we switch pages to update the DSP volume control,
but we need to switch back to page 0 before trying to alter the
soft-mute control. This latter page-switch was missing.
Fixes: ec45268467f4 ("ASoC: add support for TAS5805M digital amplifier")
Signed-off-by: Daniel Beer <daniel.beer@igorinstitute.com>
---
sound/soc/codecs/tas5805m.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/sound/soc/codecs/tas5805m.c b/sound/soc/codecs/tas5805m.c
index d720c67b9675..5cf7726904c2 100644
--- a/sound/soc/codecs/tas5805m.c
+++ b/sound/soc/codecs/tas5805m.c
@@ -203,6 +203,9 @@ static void tas5805m_refresh(struct tas5805m_priv *tas5805m)
set_dsp_scale(rm, 0x24, tas5805m->vol[0]);
set_dsp_scale(rm, 0x28, tas5805m->vol[1]);
+ regmap_write(rm, REG_PAGE, 0x00);
+ regmap_write(rm, REG_BOOK, 0x00);
+
/* Set/clear digital soft-mute */
regmap_write(rm, REG_DEVICE_CTRL_2,
(tas5805m->is_muted ? DCTRL2_MUTE : 0) |
--
2.38.1
reply other threads:[~2022-11-27 7:29 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=638311c7.a70a0220.4e021.3abe@mx.google.com \
--to=daniel.beer@igorinstitute.com \
--cc=alsa-devel@alsa-project.org \
--cc=andy-liu@ti.com \
--cc=broonie@kernel.org \
--cc=derek.simkowiak@igorinstitute.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox