From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752404AbcADQfE (ORCPT ); Mon, 4 Jan 2016 11:35:04 -0500 Received: from mout.kundenserver.de ([217.72.192.74]:60418 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751704AbcADQfB convert rfc822-to-8bit (ORCPT ); Mon, 4 Jan 2016 11:35:01 -0500 From: Arnd Bergmann To: linux-arm-kernel@lists.infradead.org Cc: Rongrong Zou , devicetree@vger.kernel.org, Catalin Marinas , Corey Minyard , gregkh@linuxfoundation.org, Will Deacon , linux-kernel@vger.kernel.org, linuxarm@huawei.com, benh@kernel.crashing.org, liviu.dudau@arm.com, Rongrong Zou Subject: Re: [PATCH v1 3/3] ARM64 LPC: update binding doc Date: Mon, 04 Jan 2016 17:34:06 +0100 Message-ID: <6384244.Uhpjfgly6O@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <568A9803.6050108@gmail.com> References: <1451396032-23708-1-git-send-email-zourongrong@gmail.com> <15026471.7nGZ0rWlIf@wuerfel> <568A9803.6050108@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT Content-Type: text/plain; charset="utf-8" X-Provags-ID: V03:K0:UxeFTbRN1d5NBVWHA3ISKAtKKNqNoejwHPFaaRTQmqOrzFpvHys Ml9Osig0CJ2VCjk05YffHanupjmsjUIocXmUlhow7hYaRnQY8zgDBAYnmJdKDgk7kIComYE ntBL5Kqm+Z9l/zYCO3pqH6Y0n+o0arPKoQGLfuzUI1iSD3gYe+PzV0diN4lUFWpoO8nR/6Y atS1nnfZwafq0L9KExu6Q== X-UI-Out-Filterresults: notjunk:1;V01:K0:oJLEb0CpkgY=:ym2o3VsD/i0KWDQxbnnRDu kDXAv0JE4nVrLCwX204U/M2lWhEPk08eRvoYqRkfDCYSC7lvwPWMr3l84Bt2Ez1FnDdcXTgEC ssDAamidi/+uCM23DZeCefTq8ak5JMJ/wnAMTi8MzFp6JvwStT+KMlZUdT5CTOWx/HGOeJmza ynIewcglNpI3MmAxlu5rgsgUTAYhdeUIjIWDk1m1bUB1cHjEumAAuF4Eqr2g4ek8n1b1mgn3K SWzgz/9E377KQuzxhKkMTBh8+AXVlBZLoB+X1Aot/Ok4GEOcH9x4rX4RCrR1pecBxIr/2wLSD yi9q9XDaGJt93t2iWh3yjGRzScj6lYWvRKQpc4QQOEeDdzQAqAx9YA5xP7pTIIY1orI7TCy/r Pim+7qLaqJjy/Wik4DwvklGsJ0SDsMYmmAroH2PzhUF1YfNwq6ij8Q7wgwahZ7R0N2eBDXquH DTt0HNBSJdfdnxy5M8+kADmaUclRAZLKxxLuTnnFSUAY2XPjYO/WL1y55esQHTnamDGkb0biQ bab/1GYQdqnHnO0F4kM8D9POIvT8H2ebNsHEhbg7idggzBrGIu8QewyWvHrZkn/cTTO8/Yyab 5P5pfRBtb3n1k1Xs7iHpKklsGYRgCt6nugsZvADdUTETd/PTts7wKtkqAYWfdcLiYUO2ikWcr UzV7dahBHJxF9YF2Czi94nvb3rcbxE7U+sBKrOltzM3QBYUFjsWwwwngu9o83Uq9m+PxxXS07 D+XTGyoP1eFvCzFT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday 05 January 2016 00:04:19 Rongrong Zou wrote: > 在 2016/1/4 19:13, Arnd Bergmann 写道: > > On Sunday 03 January 2016 20:24:14 Rongrong Zou wrote: > >> 在 2015/12/31 23:00, Rongrong Zou 写道: > >> */ > >> compatible = "low-pin-count"; > >> device_type = "isa"; > >> #address-cells = <2>; > >> #size-cells = <1>; > >> reg = <0x0 0xa01b0000 0x0 0x10000>; > >> ranges = <0x1 0x0 0x0 0x0 0x1000>; > >> /* > >> * ranges is required, then i can get the IORESOURCE_IO <0xe4,4> from "reg = <0x1, 0x000000e4, 4>". > >> * > >> */ > >> ipmi_0:ipmi@000000e4{ > >> device_type = "ipmi"; > >> compatible = "ipmi-bt"; > >> reg = <0x1 0x000000e4 0x4>; > >> }; > >> > > > > This looks wrong: the property above says that the I/O port range is > > translated to MMIO address 0x00000000 to 0x00010000, which is not > > true on your hardware. I think this needs to be changed in the code > > so the ranges property is not required for I/O ports. > > Ranges property can set empty, but this means 1:1 translation. the I/O > port range is translated to MMIO address 0x00000001 00000000 to > 0x00000001 00000004, it looks wrong else. I wonder if anyone get legacy > I/O port resource from dts. As I said, nothing should really require the ranges property here, unless you have a valid IORESOURCE_MEM translation. The code that requires the ranges to be present is wrong. > For ipmi driver, I can get I/O port resource by DMI rather than dts. No, the ipmi driver uses the resource that belongs to the platform device already, you can't rely on DMI data to be present there. Arnd