From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45DA8C433B4 for ; Mon, 12 Apr 2021 10:40:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1301B61249 for ; Mon, 12 Apr 2021 10:40:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239430AbhDLKkQ (ORCPT ); Mon, 12 Apr 2021 06:40:16 -0400 Received: from mga01.intel.com ([192.55.52.88]:27107 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237567AbhDLKkP (ORCPT ); Mon, 12 Apr 2021 06:40:15 -0400 IronPort-SDR: So6wR7sDk2qZ8vcxA+sVweJZSCAVWb3VYJzqluSqWHjpbtKSyjVhfnmkpR/G76P2vZ8Mieu/Ms CY+xSNhm9Bnw== X-IronPort-AV: E=McAfee;i="6000,8403,9951"; a="214624134" X-IronPort-AV: E=Sophos;i="5.82,216,1613462400"; d="scan'208";a="214624134" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Apr 2021 03:39:56 -0700 IronPort-SDR: /yvyGcOvJ/lkRaqfRjqQJl81c6adRXAKxZ//MrdN1qhUUUtwShVc/C7BC16CQ/VecIj9Xcunsl 5vhUFeIvI7Rw== X-IronPort-AV: E=Sophos;i="5.82,216,1613462400"; d="scan'208";a="423741123" Received: from aslawinx-mobl.ger.corp.intel.com (HELO [10.237.12.105]) ([10.237.12.105]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Apr 2021 03:39:52 -0700 Subject: Re: [PATCH v7 1/2] platform/x86: dell-privacy: Add support for Dell hardware privacy To: Perry Yuan , pobrn@protonmail.com, pierre-louis.bossart@linux.intel.com, oder_chiou@realtek.com, perex@perex.cz, tiwai@suse.com, hdegoede@redhat.com, mgross@linux.intel.com Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, lgirdwood@gmail.com, platform-driver-x86@vger.kernel.org, broonie@kernel.org, Dell.Client.Kernel@dell.com, mario.limonciello@outlook.com References: <20210412091919.27608-1-Perry_Yuan@Dell.com> From: =?UTF-8?Q?Amadeusz_S=c5=82awi=c5=84ski?= Message-ID: <63b8dca1-83d0-09ab-3622-0baa68bbf776@linux.intel.com> Date: Mon, 12 Apr 2021 12:39:50 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: <20210412091919.27608-1-Perry_Yuan@Dell.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/12/2021 11:19 AM, Perry Yuan wrote: > From: Perry Yuan > (...) > diff --git a/drivers/platform/x86/dell/dell-laptop.c b/drivers/platform/x86/dell/dell-laptop.c > index 70edc5bb3a14..e7ffc0b81208 100644 > --- a/drivers/platform/x86/dell/dell-laptop.c > +++ b/drivers/platform/x86/dell/dell-laptop.c > @@ -31,6 +31,8 @@ > #include "dell-rbtn.h" > #include "dell-smbios.h" > > +#include "dell-privacy-wmi.h" > + > struct quirk_entry { > bool touchpad_led; > bool kbd_led_not_present; > @@ -90,6 +92,7 @@ static struct rfkill *wifi_rfkill; > static struct rfkill *bluetooth_rfkill; > static struct rfkill *wwan_rfkill; > static bool force_rfkill; > +static bool has_privacy; > > module_param(force_rfkill, bool, 0444); > MODULE_PARM_DESC(force_rfkill, "enable rfkill on non whitelisted models"); > @@ -2206,10 +2209,16 @@ static int __init dell_init(void) > > if (dell_smbios_find_token(GLOBAL_MIC_MUTE_DISABLE) && > dell_smbios_find_token(GLOBAL_MIC_MUTE_ENABLE)) { > - micmute_led_cdev.brightness = ledtrig_audio_get(LED_AUDIO_MICMUTE); > - ret = led_classdev_register(&platform_device->dev, &micmute_led_cdev); > - if (ret < 0) > - goto fail_led; > + if (dell_privacy_present()) > + has_privacy = true; > + else > + has_privacy = false; Bit, of nitpicking, but you can write above shorter: has_privacy = dell_privacy_present();