From: Nathan Lynch <Nathan_Lynch@mentor.com>
To: Kees Cook <keescook@chromium.org>
Cc: Jisheng Zhang <jszhang@marvell.com>,
Russell King <linux@armlinux.org.uk>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ARM: VDSO: put read only/mostly objects into proper sections
Date: Wed, 10 Aug 2016 14:04:58 -0500 [thread overview]
Message-ID: <63c1b715-5e71-b503-d1fc-e5622e53b815@mentor.com> (raw)
In-Reply-To: <CAGXu5jJCjk-3nBcMamJhpK7m+qfcdu6mvD6heYR=gJkAO40Jxg@mail.gmail.com>
On 08/10/2016 01:47 PM, Kees Cook wrote:
> On Wed, Aug 10, 2016 at 2:59 AM, Jisheng Zhang <jszhang@marvell.com> wrote:
>> + Kees
>>
>> On Wed, 10 Aug 2016 17:09:47 +0800 wrote:
>>
>>> vdso_data_mapping is never modified, so mark it as const.
>>>
>>> vdso_data_page and vdso_text_mapping are initialized by vdso_init(),
>>> thereafter are mostly read during vdso special mapping handling.
>>>
>>> The fact that they are mostly read and not written to makes them
>>> candidates for __read_mostly declarations.
>>
>> Inspired by Kees's "arm: apply more __ro_after_init", is it better
>> to mark these vars as __ro_after_init?
>
> Yeah, if they're not written outside of __init, please do. It would be
> a nice complement to commit 11bf9b865898 ("ARM/vdso: Mark the vDSO
> code read-only after init").
I agree.
prev parent reply other threads:[~2016-08-10 19:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-10 9:09 [PATCH] ARM: VDSO: put read only/mostly objects into proper sections Jisheng Zhang
2016-08-10 9:59 ` Jisheng Zhang
2016-08-10 18:47 ` Kees Cook
2016-08-10 19:04 ` Nathan Lynch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=63c1b715-5e71-b503-d1fc-e5622e53b815@mentor.com \
--to=nathan_lynch@mentor.com \
--cc=jszhang@marvell.com \
--cc=keescook@chromium.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox