From: Kees Cook <keescook@chromium.org>
To: Mark Rutland <mark.rutland@arm.com>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>, John Stultz <jstultz@google.com>,
Yongqin Liu <yongqin.liu@linaro.org>,
Sami Tolvanen <samitolvanen@google.com>,
Ard Biesheuvel <ardb@kernel.org>,
Yury Norov <yury.norov@gmail.com>,
Andrey Konovalov <andreyknvl@gmail.com>,
Marco Elver <elver@google.com>,
linux-arm-kernel@lists.infradead.org, llvm@lists.linux.dev,
Nathan Chancellor <nathan@kernel.org>,
Nick Desaulniers <ndesaulniers@google.com>,
Tom Rix <trix@redhat.com>,
Alexander Potapenko <glider@google.com>,
linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org
Subject: Re: [PATCH] arm64: Support Clang UBSAN trap codes for better reporting
Date: Fri, 3 Feb 2023 16:32:16 +0000 [thread overview]
Message-ID: <63dd3711.170a0220.c22c8.349c@mx.google.com> (raw)
In-Reply-To: <Y9zawkok2AWy/brZ@FVFF77S0Q05N>
On Fri, Feb 03, 2023 at 09:58:26AM +0000, Mark Rutland wrote:
> On Thu, Feb 02, 2023 at 10:36:57PM +0000, Kees Cook wrote:
> > On arm64, Clang encodes the UBSAN check type in the esr. Extract this
> > and actually report UBSAN traps with some specificity when building with
> > CONFIG_UBSAN_TRAP. Before:
>
> Really minor nit, but could we mention CONFIG_UBSAN_TRAP at the start, e.g.
> change that first sentence to:
>
> | When CONFIG_UBSAN_TRAP=y on arm64, Clang encodes the UBSAN check type into a
> | BRK immediate, which is reported in the ESR.
>
> I was initially confused since I was aware that there are usually direct
> function calls for the reporting.
Sure, I can rearrange the commit log.
>
> Other than that, this looks fine to me, and regardless of the above:
>
> Acked-by: Mark Rutland <mark.rutland@arm.com>
Thanks!
-Kees
--
Kees Cook
next prev parent reply other threads:[~2023-02-03 16:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-02 22:36 [PATCH] arm64: Support Clang UBSAN trap codes for better reporting Kees Cook
2023-02-02 22:48 ` John Stultz
2023-02-03 9:58 ` Mark Rutland
2023-02-03 16:32 ` Kees Cook [this message]
2023-02-03 11:34 ` Ard Biesheuvel
2023-02-03 16:36 ` Kees Cook
2023-02-03 13:27 ` Mukesh Ojha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=63dd3711.170a0220.c22c8.349c@mx.google.com \
--to=keescook@chromium.org \
--cc=andreyknvl@gmail.com \
--cc=ardb@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=elver@google.com \
--cc=glider@google.com \
--cc=jstultz@google.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=mark.rutland@arm.com \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=samitolvanen@google.com \
--cc=trix@redhat.com \
--cc=will@kernel.org \
--cc=yongqin.liu@linaro.org \
--cc=yury.norov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox