From: Kees Cook <keescook@chromium.org>
To: Namjae Jeon <linkinjeon@kernel.org>
Cc: Steve French <sfrench@samba.org>, Paulo Alcantara <pc@cjr.nz>,
Ronnie Sahlberg <lsahlber@redhat.com>,
Shyam Prasad N <sprasad@microsoft.com>,
Tom Talpey <tom@talpey.com>,
Sergey Senozhatsky <senozhatsky@chromium.org>,
linux-cifs@vger.kernel.org, linux-kernel@vger.kernel.org,
samba-technical@lists.samba.org, linux-hardening@vger.kernel.org
Subject: Re: [PATCH v2] smb3: Replace smb2pdu 1-element arrays with flex-arrays
Date: Fri, 17 Feb 2023 16:13:03 -0800 [thread overview]
Message-ID: <63f01810.170a0220.110a8.6fe1@mx.google.com> (raw)
In-Reply-To: <CAKYAXd-fcukmXfdwiAxOxe+5c+Y6vvaoQ3ff-5sK+Zis0HgC5A@mail.gmail.com>
On Thu, Feb 16, 2023 at 11:25:01PM +0900, Namjae Jeon wrote:
> Hi Kees,
>
> > /* Read flags */
> > @@ -730,7 +730,7 @@ struct smb2_read_rsp {
> > __le32 DataLength;
> > __le32 DataRemaining;
> > __le32 Flags;
> > - __u8 Buffer[1];
> > + __u8 Buffer[];
> > } __packed;
> >
>
> You seem to have missed -1 removal in the code below.
Ah; thanks for this heads-up. I will need a v3.
> ./fs/cifs/smb2ops.c:5632: .read_rsp_size = sizeof(struct
> smb2_read_rsp) - 1,
> ./fs/cifs/smb2ops.c:5654: .read_rsp_size = sizeof(struct
> smb2_read_rsp) - 1,
...
These are interesting -- they don't show up at all in the code. What I
mean is that they're data-only changes. I'll add that to my before/after
build sanity checks.
Thanks!
-Kees
--
Kees Cook
prev parent reply other threads:[~2023-02-18 0:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-14 23:29 [PATCH v2] smb3: Replace smb2pdu 1-element arrays with flex-arrays Kees Cook
2023-02-16 14:25 ` Namjae Jeon
2023-02-18 0:13 ` Kees Cook [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=63f01810.170a0220.110a8.6fe1@mx.google.com \
--to=keescook@chromium.org \
--cc=linkinjeon@kernel.org \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lsahlber@redhat.com \
--cc=pc@cjr.nz \
--cc=samba-technical@lists.samba.org \
--cc=senozhatsky@chromium.org \
--cc=sfrench@samba.org \
--cc=sprasad@microsoft.com \
--cc=tom@talpey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox