From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 81E1D275AF5 for ; Wed, 1 Oct 2025 08:24:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759307053; cv=none; b=szG78MGaqP0mhqjtZXHXJVYOYOiCzxtIO8XOHmutpdkzAH46WgSUa286+ZpUam1NyQC+8Mwuv2rtIn26A0gllMF/sSkSmGifwh2icecxqR34ftX5ajaWVy6ZsfdunurAqRWZ4/0KT5J6he8y4Ea3dKCF+EBJcxqNqZIfH9+8PTw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759307053; c=relaxed/simple; bh=+clJ7vL0rYP0PU+9eKAOYozUc2CoLqMkOXgjFChnTaA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Q/0g9XsfYlyToYwVlbzd4oB8JDVG5zmsmKk5Yh/XAMzEBBGu178pLCJkp9bN9TqxOjtxLpqpdCiV6FqyRUZUFHmzHiFZwauPfwWQncx6eKhGmLg5SJjmR9Zwq3jqFzbQESYKcClxLdEgA+9m2ojQIMfLCEHrqMk8cph4+vTjaso= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=kk20w8N/; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="kk20w8N/" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 5917gqpA013504 for ; Wed, 1 Oct 2025 08:24:09 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 9WeCZ8nODB+BE/0tMdVsmrnabswaxwFpBtLmdZ7Nur8=; b=kk20w8N/ftOiMHI2 s+24PDgXUvUrdO5LF8zHRs4jQ0x056L8LAAkKL/4ZGuyiwdAs159BmPNicI4XeMi XAIhFiyB7/BnztmcA4VPvtJTOBZcTf7fj/uggYzAeEq9X9DH4kOiAL1lZxcm6rlD szhxRyyNqc27ixyGE1LqzORtIrnWYcRNxj+4aKzWLadRgOqMYhnxiFclIvNOXbEZ E3Rlv9QWvcmJk8WNzIlqIxOZhxju0YlRgfmSqCe/JRvIWjJoZCeMtY+9+tQ+cBqg iyXG/5l8Q7ADiUcfVxpmTIQGXEuuOlTFFjieVVXPi2WKdY8dPMZFm6hf4Vv9TjEJ QWHunQ== Received: from mail-pf1-f200.google.com (mail-pf1-f200.google.com [209.85.210.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 49e8a63w5r-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Wed, 01 Oct 2025 08:24:09 +0000 (GMT) Received: by mail-pf1-f200.google.com with SMTP id d2e1a72fcca58-76e2eb787f2so5774694b3a.3 for ; Wed, 01 Oct 2025 01:24:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759307048; x=1759911848; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=9WeCZ8nODB+BE/0tMdVsmrnabswaxwFpBtLmdZ7Nur8=; b=gw/lFdA62JhJo5IYEiuB7M1lasAB1lug76pm1Tvl/mCQz1WNtx4gh27n4quUUmvNL4 HPhxH5TJqX66frwtdxxNgGFgkhATeB1gKmUznhpf5v/0zTL+16EcAO1YWI+Boevuxv9a LegJHMTgqHNACzD+ca+Lbq9z9pXAft8/LhBq9Aq/P3cNsUzReVjzgfHE5t7WTHmHW+P1 wEk68yw9601+aHUJ/uYmbkUw2EHWVnY1LSE0CJKYcXp8FcC2kaTwcGAwNqd6vPzY6GLy LOWmbT9Vs5oVlszSdsMh/zTIreAs/nzFA1Pjh+hPtamgLhzLntRXqFD0GGuXYjM96boG Gkaw== X-Forwarded-Encrypted: i=1; AJvYcCXHwF3O/fOkcYHoMv1enEYMR+QAsUWpKIlB9BCbkWLh0Q2Pg70AabrKFH5xKtCuJYEGwYgxNUFE7w+WNp4=@vger.kernel.org X-Gm-Message-State: AOJu0YymF8dp5ZJ2VWQlEpTA4DC94uiga9mb2EzWk5o3MmpFEHv3/QN2 SlbnX1S35tB/Y8bkOYNo1p6Hf7Yz+OPBC2P6THjKhGuYfRNfLj+g0H70miB/ZXF917uaOITAvMz y6itUnQoe0buMMlIUKiusCzOrC3T5QdhdJYXzVMVCmr+Ffd9GGyl6qrXOwuWUo8/VSX8= X-Gm-Gg: ASbGncthMjbP/MBAr0Y+FTE5eA9XU/lXPuCSUGxMX9pJ2F2wr7+ak6P4FKBjA6QlEwj 41J4M8IgpmdDwbg5wwdTpKXuhvsJNnW3sEHbc8G3kVmE0AFGP4p6C45jSmfIB322YX04G38ySL/ Xo5qKc+TWiQsnn30eS+v7mKlvUAGYyeQjs6/BaFYmMK+JqLwW8ulUFhF93ClWIIG+RyGZfXhjVq s4QYJtpLZq8QD8W+plpyYxSc6iqg2zBYziHVDOCoWmyhU/HLhYbsNIHD773ApjIjuQvHQjAbRK4 u0J/MXssjw6Mtpasq+w4pd0Sqana/EM+jaG9V1m9l3REENLyUm/uYTKrKfOIWzUkuD1uR8gUjDE 33Wk= X-Received: by 2002:a05:6a00:a28:b0:772:2e00:831f with SMTP id d2e1a72fcca58-78af3fe8acamr3172149b3a.4.1759307047763; Wed, 01 Oct 2025 01:24:07 -0700 (PDT) X-Google-Smtp-Source: AGHT+IH+1vDkQo6+qHms4dPxWVBLyluPAupo+qgWQXu4cRIxAyzzN0qF87jp7WdFFUlrd4ofL8WQKw== X-Received: by 2002:a05:6a00:a28:b0:772:2e00:831f with SMTP id d2e1a72fcca58-78af3fe8acamr3172120b3a.4.1759307047252; Wed, 01 Oct 2025 01:24:07 -0700 (PDT) Received: from [10.0.0.86] ([106.222.229.252]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-78102c06981sm15689317b3a.72.2025.10.01.01.24.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 01 Oct 2025 01:24:06 -0700 (PDT) Message-ID: <63f593cd-9b57-0e23-e8ac-54f160cd5ed1@oss.qualcomm.com> Date: Wed, 1 Oct 2025 13:54:02 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH 1/2] media: iris: Add support for QC08C format for decoder Content-Language: en-US To: Dmitry Baryshkov Cc: Vikash Garodia , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab , linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20250919-video-iris-ubwc-enable-v1-0-000d11edafd8@oss.qualcomm.com> <20250919-video-iris-ubwc-enable-v1-1-000d11edafd8@oss.qualcomm.com> <81932285-b007-7cdf-a28d-21131a26eb85@oss.qualcomm.com> From: Dikshita Agarwal In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=RZKdyltv c=1 sm=1 tr=0 ts=68dce529 cx=c_pps a=mDZGXZTwRPZaeRUbqKGCBw==:117 a=L4UNg9I9cQSOxNpRiiGXlA==:17 a=IkcTkHD0fZMA:10 a=x6icFKpwvdMA:10 a=P-IC7800AAAA:8 a=EUspDBNiAAAA:8 a=M6TxIu9XhMF2Uok1x6sA:9 a=QEXdDO2ut3YA:10 a=zc0IvFSfCIW2DFIPzwfm:22 a=d3PnA9EDa4IxuAV0gXij:22 X-Proofpoint-GUID: Eu22f9I8ZzYZpkTO4vwBPATzyyJSAVIT X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwOTI3MDAzMyBTYWx0ZWRfX/oH6YkoiiP7U K2lf/WWzKhbx8r6k4SzkQvbLQDvjktJSADvH+oMH0rBdcGht6jzpSf3cNBvjiYeMP3LimiurGTx lpcfShS4Ic+Y0CBtYjLpgqNYC7b+mmt6yAYdYAAiPxFyhU0LE9GqEjAjb9WvOEc4Qws0eayUvd/ 69W4p1g0R0KBZfu0BGtSOU33CfbR1wVJJ9GUVc3c9wbo3HqxerEW4CGTWWtXnvNwyRzArbu0aDx 74DwMMbfYswiTse2nQmXa/p5t8QitiqoGOlX9C13aLi9u8l0HPGAQl1BFlOZXcz7vQKeg7sE68o BwQHtRDnlv4jeB/UnD/EC8mBUJYO/wjCvP+eUlDLl6p3R7FOPY26KgPrynnXIDvOMB5WSKCjlaa nkPuEUmLYaVZj0159Yi+w1urJQvVhA== X-Proofpoint-ORIG-GUID: Eu22f9I8ZzYZpkTO4vwBPATzyyJSAVIT X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1117,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-10-01_02,2025-09-29_04,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 malwarescore=0 priorityscore=1501 adultscore=0 phishscore=0 impostorscore=0 spamscore=0 bulkscore=0 lowpriorityscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2509150000 definitions=main-2509270033 On 9/24/2025 9:53 PM, Dmitry Baryshkov wrote: > On Wed, Sep 24, 2025 at 04:24:07PM +0530, Dikshita Agarwal wrote: >> >> >> On 9/19/2025 10:24 PM, Dmitry Baryshkov wrote: >>> On Fri, Sep 19, 2025 at 09:17:16PM +0530, Dikshita Agarwal wrote: >>>> Introduce handling for the QC08C format in the decoder. >>>> Update format checks and configuration to enable decoding of QC08C >>>> streams. >>> >>> What is QC08C? Is it supported on all devices? >> >> It's qualcomm specific compressed format, it's defined here >> https://elixir.bootlin.com/linux/v6.17-rc2/source/include/uapi/linux/videodev2.h#L820 >> >> And Yes, it's supported on all Qualcomm devices supported by iris driver. > > Is it going to be supported by all platforms that are going to be > migrated from Venus to Iris? Yes, for all hardware which supports UBWC. > > Is it just NV12 + UBWC or something else? Yes it's NV12 + UBWC compression. > >> >>> >>>> >>>> Signed-off-by: Dikshita Agarwal >>>> --- >>>> drivers/media/platform/qcom/iris/iris_buffer.c | 5 +- >>>> .../platform/qcom/iris/iris_hfi_gen1_command.c | 12 +++-- >>>> .../platform/qcom/iris/iris_hfi_gen2_command.c | 18 ++++++- >>>> .../platform/qcom/iris/iris_hfi_gen2_defines.h | 1 + >>>> drivers/media/platform/qcom/iris/iris_instance.h | 7 ++- >>>> .../media/platform/qcom/iris/iris_platform_gen2.c | 1 + >>>> drivers/media/platform/qcom/iris/iris_utils.c | 3 +- >>>> drivers/media/platform/qcom/iris/iris_vdec.c | 61 ++++++++++++++++++---- >>>> 8 files changed, 89 insertions(+), 19 deletions(-) >>>> >>>> diff --git a/drivers/media/platform/qcom/iris/iris_instance.h b/drivers/media/platform/qcom/iris/iris_instance.h >>>> index 5982d7adefeab80905478b32cddba7bd4651a691..11134f75c26dd1f6c92ba72fbf4e56e41a72de64 100644 >>>> --- a/drivers/media/platform/qcom/iris/iris_instance.h >>>> +++ b/drivers/media/platform/qcom/iris/iris_instance.h >>>> @@ -15,12 +15,17 @@ >>>> #define DEFAULT_WIDTH 320 >>>> #define DEFAULT_HEIGHT 240 >>>> >>>> -enum iris_fmt_type { >>>> +enum iris_fmt_type_out { >>>> IRIS_FMT_H264, >>>> IRIS_FMT_HEVC, >>>> IRIS_FMT_VP9, >>>> }; >>>> >>>> +enum iris_fmt_type_cap { >>>> + IRIS_FMT_NV12, >>>> + IRIS_FMT_UBWC, >>> >>> UBWC is not a format on its own, it's a modifier of the format. Please >>> come up with a better naming. >> >> Sure, will rename this to IRIS_FMT_QC08C inline with v4l2 definition. > > Ack. > >