From: Paolo Abeni <pabeni@redhat.com>
To: Chuang Wang <nashuiliang@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] net: macvlan: Use built-in RCU list checking
Date: Thu, 10 Nov 2022 11:57:22 +0100 [thread overview]
Message-ID: <63f95025240ce6fa9d9c57ac26875d67dfd2bc71.camel@redhat.com> (raw)
In-Reply-To: <20221108125254.688234-1-nashuiliang@gmail.com>
Hello,
On Tue, 2022-11-08 at 20:52 +0800, Chuang Wang wrote:
> hlist_for_each_entry_rcu() has built-in RCU and lock checking.
>
> Pass cond argument to hlist_for_each_entry_rcu() to silence false
> lockdep warning when CONFIG_PROVE_RCU_LIST is enabled.
>
> Execute as follow:
>
> ip link add link eth0 type macvlan mode source macaddr add <MAC-ADDR>
>
> The rtnl_lock is held when macvlan_hash_lookup_source() or
> macvlan_fill_info_macaddr() are called in the non-RCU read side section.
> So, pass lockdep_rtnl_is_held() to silence false lockdep warning.
>
> Signed-off-by: Chuang Wang <nashuiliang@gmail.com>
The patch LGTM, but IMHO this should target the -net tree, as it's
addressing an issue bothering people.
Can you please re-submit, specifying the target tree into the subj and
including a suitable Fixes tag?
Thanks!
Paolo
next prev parent reply other threads:[~2022-11-10 10:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-08 12:52 [PATCH v1] net: macvlan: Use built-in RCU list checking Chuang Wang
2022-11-10 10:57 ` Paolo Abeni [this message]
2022-11-10 11:27 ` Chuang W
2022-11-10 16:46 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=63f95025240ce6fa9d9c57ac26875d67dfd2bc71.camel@redhat.com \
--to=pabeni@redhat.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nashuiliang@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox