From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6B37118AE2; Wed, 22 Jan 2025 11:23:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737545015; cv=none; b=d21VgWwOeo5OliLpQMwhkDBZiRS+R/kFLX4bxN52cvtflnZWL3FuFZEB7jBKs6J/ups99ci4wq85aBmy39nstQ3mTyF0AhnlOJ1gg4Z7zAiHfFgZPhdS7gBea3nFVtFEXlEUKr4QfSuZtipHnT/UzsdBQ1d4EI/7msjHVvx1dHI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737545015; c=relaxed/simple; bh=DFW0ySEcK5zFjneu/zUnRvTXguR+9mng1b4DYDONaVo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=imD5UCEGIbHBz3xIxYrIEUE4ehKTymZHoq344Fe34ZGXbdGvOHrsyGGBjbHFzUpGuFMV2k65omChzEeZ8trR8LHoQl2oaKgxkRD06PdLregmdxN14tPQbFFD5vUAKIjBCOJ1jXUmkNO90bJMn5bPX9i9JG15EWoSiRHM4c7DbdY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=djO+2sMk; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="djO+2sMk" Received: by smtp.kernel.org (Postfix) with ESMTPSA id EE875C4CED6; Wed, 22 Jan 2025 11:23:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1737545014; bh=DFW0ySEcK5zFjneu/zUnRvTXguR+9mng1b4DYDONaVo=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=djO+2sMkz8+eS4i6SG8RSsbqT1Qg+JaOY92qmyJP/PdDFXYo504FdqDUuoRdF8is4 ky8k1v3l/qh4FBOuUhImZf6s/P9rj11MhHhOV536mmEFOIdrXwrLm8X2C6AwXmKWvD BXwMz3XWx+jDlFf//y7VsK/DQ1ojlmsW5EIS4whXpi6jeHWnK6gxXaU61Z9v6cTKIF uuS6hcRx4POoefQ9WMzEcvf2xkSjjhVJzHTGTucVBRBRFVIuaS90VizRXsEi71VrQv dgDnRms3xRakDu4pdjnEPoR69QlBAWND+Z0x07uSOXHDb7QbfzCbluYE6KXHW72row lU/xaOFNngFaA== Message-ID: <63fb9cc6-b57c-45bc-8da2-7bcb871d9887@kernel.org> Date: Wed, 22 Jan 2025 12:23:27 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [EXT] Re: [PATCH v12 4/5] firmware: imx: add driver for NXP EdgeLock Enclave To: Pankaj Gupta , Jonathan Corbet , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam Cc: "linux-doc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" , "imx@lists.linux.dev" , "linux-arm-kernel@lists.infradead.org" References: <20250120-imx-se-if-v12-0-c5ec9754570c@nxp.com> <20250120-imx-se-if-v12-4-c5ec9754570c@nxp.com> <2fb2db33-9d45-442a-bfb9-55173751f20f@kernel.org> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJgPO8PBQkUX63hAAoJEBuTQ307 QWKbBn8P+QFxwl7pDsAKR1InemMAmuykCHl+XgC0LDqrsWhAH5TYeTVXGSyDsuZjHvj+FRP+ gZaEIYSw2Yf0e91U9HXo3RYhEwSmxUQ4Fjhc9qAwGKVPQf6YuQ5yy6pzI8brcKmHHOGrB3tP /MODPt81M1zpograAC2WTDzkICfHKj8LpXp45PylD99J9q0Y+gb04CG5/wXs+1hJy/dz0tYy iua4nCuSRbxnSHKBS5vvjosWWjWQXsRKd+zzXp6kfRHHpzJkhRwF6ArXi4XnQ+REnoTfM5Fk VmVmSQ3yFKKePEzoIriT1b2sXO0g5QXOAvFqB65LZjXG9jGJoVG6ZJrUV1MVK8vamKoVbUEe 0NlLl/tX96HLowHHoKhxEsbFzGzKiFLh7hyboTpy2whdonkDxpnv/H8wE9M3VW/fPgnL2nPe xaBLqyHxy9hA9JrZvxg3IQ61x7rtBWBUQPmEaK0azW+l3ysiNpBhISkZrsW3ZUdknWu87nh6 eTB7mR7xBcVxnomxWwJI4B0wuMwCPdgbV6YDUKCuSgRMUEiVry10xd9KLypR9Vfyn1AhROrq AubRPVeJBf9zR5UW1trJNfwVt3XmbHX50HCcHdEdCKiT9O+FiEcahIaWh9lihvO0ci0TtVGZ MCEtaCE80Q3Ma9RdHYB3uVF930jwquplFLNF+IBCn5JRzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmA872oFCRRflLYACgkQG5NDfTtBYpvScw/9GrqBrVLuJoJ52qBBKUBDo4E+5fU1bjt0 Gv0nh/hNJuecuRY6aemU6HOPNc2t8QHMSvwbSF+Vp9ZkOvrM36yUOufctoqON+wXrliEY0J4 ksR89ZILRRAold9Mh0YDqEJc1HmuxYLJ7lnbLYH1oui8bLbMBM8S2Uo9RKqV2GROLi44enVt vdrDvo+CxKj2K+d4cleCNiz5qbTxPUW/cgkwG0lJc4I4sso7l4XMDKn95c7JtNsuzqKvhEVS oic5by3fbUnuI0cemeizF4QdtX2uQxrP7RwHFBd+YUia7zCcz0//rv6FZmAxWZGy5arNl6Vm lQqNo7/Poh8WWfRS+xegBxc6hBXahpyUKphAKYkah+m+I0QToCfnGKnPqyYIMDEHCS/RfqA5 t8F+O56+oyLBAeWX7XcmyM6TGeVfb+OZVMJnZzK0s2VYAuI0Rl87FBFYgULdgqKV7R7WHzwD uZwJCLykjad45hsWcOGk3OcaAGQS6NDlfhM6O9aYNwGL6tGt/6BkRikNOs7VDEa4/HlbaSJo 7FgndGw1kWmkeL6oQh7wBvYll2buKod4qYntmNKEicoHGU+x91Gcan8mCoqhJkbqrL7+nXG2 5Q/GS5M9RFWS+nYyJh+c3OcfKqVcZQNANItt7+ULzdNJuhvTRRdC3g9hmCEuNSr+CLMdnRBY fv0= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 22/01/2025 12:13, Pankaj Gupta wrote: > > > -----Original Message----- From: Krzysztof Kozlowski > > Sent: Monday, January 20, 2025 5:54 PM To: Pankaj > Gupta >; Jonathan Corbet >; > Rob Herring >; Krzysztof Kozlowski > >; Conor Dooley >; Shawn > Guo >; Sascha Hauer >; > Pengutronix Kernel Team >; Fabio Estevam > > Cc: linux-doc@vger.kernel.org; linux- > kernel@vger.kernel.org; devicetree@vger.kernel.org; > imx@lists.linux.dev; linux-arm-kernel@lists.infradead.org Subject: > [EXT] Re: [PATCH v12 4/5] firmware: imx: add driver for NXP EdgeLock > Enclave > > Caution: This is an external email. Please take care when clicking > links or opening attachments. When in doubt, report the message > using the 'Report this email' button You got comment on this, more than once. Rest of the email is poorly formatted, so I am just skimming through it. Fix your email program to send readable content if you want some answers for stuff I missed. I expect all my comments fully addressed, not just some of them. >>> + +static int se_if_probe(struct platform_device *pdev) { + >>> const struct se_if_node_info_list *info_list; + const struct >>> se_if_node_info *info; + struct device *dev = &pdev->>dev; >>> + struct se_fw_load_info *load_fw; + struct se_if_priv >>> *priv; + u32 idx; + int ret; +q + idx = >>> GET_IDX_FROM_DEV_NODE_NAME(dev->>of_node); > >> NAK. Node can be called firmware and your entire driver collapes. > The macro is updated to verify the correct-ness of node-name. NAK, do you understand the term? I provided the reasons for NAK. > > + (!memcmp(dev_of_node->full_name, NODE_NAME, > strlen(NODE_NAME)) ?\ ((strlen(dev_of_node->full_name) > > strlen(NODE_NAME)) ?\ GET_ASCII_TO_U8((strlen(dev_of_node- > >full_name) - strlen(NODE_NAME)),\ dev_of_node- > >full_name[strlen(NODE_NAME) + 1], \ - > dev_of_node->full_name[strlen(NODE_NAME) + 2]) : 0) > + dev_of_node- > >full_name[strlen(NODE_NAME) + 2]) : 0) : -EINVAL) > >>> + info_list = device_get_match_data(dev); + if (idx >>= >>> info_list->>num_mu) { + dev_err(dev, >>> + "Incorrect node name :%s\n", >>> + dev->>of_node->>full_name); > >> Nope. "firmware" or "secure" are correct node names. > New check is added to validate the correctness of the node name for > this driver. Replaced the message of " Incorrect node name..", with > the help message. You did not resolve the NAK. 1. You cannot reject correct names. 2. You cannot add undocumented ABI. You could try to document it, but it will not solve the first problem. Best regards, Krzysztof