From: Damien Le Moal <dlemoal@kernel.org>
To: Sasha Levin <sashal@kernel.org>
Cc: Mikhail Ukhin <mish.uxin2012@yandex.ru>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jens Axboe <axboe@kernel.dk>, Niklas Cassel <cassel@kernel.org>,
stable@vger.kernel.org, linux-ide@vger.kernel.org,
linux-kernel@vger.kernel.org,
Pavel Koshutin <koshutin.pavel@yandex.ru>,
lvc-project@linuxtesting.org
Subject: Re: [PATCH v4 5.10/5.15] ata: libata-scsi: check cdb length for VARIABLE_LENGTH_CMD commands
Date: Fri, 28 Jun 2024 12:44:43 +0900 [thread overview]
Message-ID: <6408b923-d9e8-4a86-bd0d-7cbe050433e6@kernel.org> (raw)
In-Reply-To: <Zn3Gzc46q_gXoD59@sashalap>
On 6/28/24 5:08 AM, Sasha Levin wrote:
> On Thu, Jun 27, 2024 at 11:02:23AM +0900, Damien Le Moal wrote:
>> On 6/27/24 06:13, Mikhail Ukhin wrote:
>>> Fuzzing of 5.10 stable branch reports a slab-out-of-bounds error in
>>> ata_scsi_pass_thru.
>>>
>>> The error is fixed in 5.18 by commit ce70fd9a551a ("scsi: core: Remove the
>>> cmd field from struct scsi_request") upstream.
>>> Backporting this commit would require significant changes to the code so
>>> it is bettter to use a simple fix for that particular error.
>>
>> This sentence is not needed in the commit message. That is a discussion to have
>> when applying (or not) the patch.
>
> It's good to have this reasoning in the commit message to, so that later
> when we look at the patch and try to understand why we needed something
> custom for the backport, the justification will be right there.
OK then, let's keep the commit message as it is.
Mikhail,
Please send a v5 patch with the correction I commented and the patch will be
good to go.
Thanks !
--
Damien Le Moal
Western Digital Research
prev parent reply other threads:[~2024-06-28 3:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-26 21:13 [PATCH v4 5.10/5.15] ata: libata-scsi: check cdb length for VARIABLE_LENGTH_CMD commands Mikhail Ukhin
2024-06-27 2:02 ` Damien Le Moal
2024-06-27 20:08 ` Sasha Levin
2024-06-28 3:44 ` Damien Le Moal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6408b923-d9e8-4a86-bd0d-7cbe050433e6@kernel.org \
--to=dlemoal@kernel.org \
--cc=axboe@kernel.dk \
--cc=cassel@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=koshutin.pavel@yandex.ru \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lvc-project@linuxtesting.org \
--cc=mish.uxin2012@yandex.ru \
--cc=sashal@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox