From: Kees Cook <keescook@chromium.org>
To: Nick Desaulniers <ndesaulniers@google.com>
Cc: Shuah Khan <shuah@kernel.org>,
Linux Kernel Functional Testing <lkft@linaro.org>,
Naresh Kamboju <naresh.kamboju@linaro.org>,
KERNEL SELFTEST FRAMEWORK <linux-kselftest@vger.kernel.org>,
linux-api@vger.kernel.org, linux-kernel@vger.kernel.org,
lkft-triage@lists.linaro.org,
Thomas Gleixner <tglx@linutronix.de>,
"Chang S. Bae" <chang.seok.bae@intel.com>,
Len Brown <len.brown@intel.com>, Borislav Petkov <bp@suse.de>,
Stas Sergeev <stsp@list.ru>, Arnd Bergmann <arnd@arndb.de>,
Anders Roxell <anders.roxell@linaro.org>,
Andy Lutomirski <luto@kernel.org>,
Nathan Chancellor <nathan@kernel.org>,
llvm@lists.linux.dev
Subject: Re: [PATCH] selftests: sigaltstack: fix -Wuninitialized
Date: Wed, 8 Mar 2023 16:01:46 -0800 [thread overview]
Message-ID: <640921eb.170a0220.28e72.38c8@mx.google.com> (raw)
In-Reply-To: <20230308195933.806917-1-ndesaulniers@google.com>
On Wed, Mar 08, 2023 at 11:59:33AM -0800, Nick Desaulniers wrote:
> Building sigaltstack with clang via:
> $ ARCH=x86 make LLVM=1 -C tools/testing/selftests/sigaltstack/
>
> produces the following warning:
> warning: variable 'sp' is uninitialized when used here [-Wuninitialized]
> if (sp < (unsigned long)sstack ||
> ^~
>
> Clang expects these to be declared at global scope; we've fixed this in
> the kernel proper by using the macro `current_stack_pointer`. This is
> defined in different headers for different target architectures, so just
> create a new header that defines the arch-specific register names for
> the stack pointer register, and define it for more targets (at least the
> ones that support current_stack_pointer/ARCH_HAS_CURRENT_STACK_POINTER).
>
> Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>
> Link: https://lore.kernel.org/lkml/CA+G9fYsi3OOu7yCsMutpzKDnBMAzJBCPimBp86LhGBa0eCnEpA@mail.gmail.com/
> Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
Looks good!
Reviewed-by: Kees Cook <keescook@chromium.org>
--
Kees Cook
next prev parent reply other threads:[~2023-03-09 0:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-08 19:59 [PATCH] selftests: sigaltstack: fix -Wuninitialized Nick Desaulniers
2023-03-09 0:01 ` Kees Cook [this message]
2023-03-13 9:50 ` Naresh Kamboju
2023-03-20 18:41 ` Nick Desaulniers
2023-03-20 23:30 ` shuah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=640921eb.170a0220.28e72.38c8@mx.google.com \
--to=keescook@chromium.org \
--cc=anders.roxell@linaro.org \
--cc=arnd@arndb.de \
--cc=bp@suse.de \
--cc=chang.seok.bae@intel.com \
--cc=len.brown@intel.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=lkft-triage@lists.linaro.org \
--cc=lkft@linaro.org \
--cc=llvm@lists.linux.dev \
--cc=luto@kernel.org \
--cc=naresh.kamboju@linaro.org \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=shuah@kernel.org \
--cc=stsp@list.ru \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox