From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Google-Smtp-Source: ACJfBosQOOthwgpaw3dzoVwMzPrp4zYQBqgfTg8uXjworcXjrNk0e1xVV1p99VO/x1AjscpGtpsv ARC-Seal: i=1; a=rsa-sha256; t=1516298403; cv=none; d=google.com; s=arc-20160816; b=MnA36Lw+4pPGfvwGVMP26egpDyHluNF2thomXEK/Ul8c8TnH27AXPoDlQt7PKeTy7L gYmam8KEw47RVeGkT5ndSUuh6wxMG8ddvMqXk7S2GNB89tf0bw9OHCVVJ1mnTX8JZ4UG ARPQSGFttD1cCV0B1fGu+CsPvNG1MHOcGEXHiR6f+A+GmBdyrUK9hsFi0am3BWys7A3x TsixUQELbI6mDwXJuhNONqgPm8Yb3Zfn0NydiVTJLtMfNIz5/tm1635xTtqDwiiZnPbv yaL5EACj+UUZnZ+FzT97GA/8AgpjZMdsQH8/LqIYiA/3CHNPYL9lf9JD3dI/RRVJTc4V c0RA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=user-agent:message-id:references:in-reply-to:subject:cc:to:from :date:content-transfer-encoding:mime-version:dkim-signature :dkim-signature:arc-authentication-results; bh=9n0v6ozUqFZuHD/GA7V98f+v2rw0KeMDJl7zR5pjP04=; b=WSChbFKTMOalMx3y3EttS61cLayUMP8NWgMAKXsMaEgC0LUbzepypYtvIR2f2zzJBX s5bUSqnKdmN7hqoHq+0M6kIFQ/5JCe2mFElFvDWQtStoMEZN/qXurz5PZwN4tpDxR8vU dDjmnkPzW3s64X8ALbwXs2LF/ePDSE3v2tJmbREXaS4J74ajszTnLyeXGDwd0skyXqZG vmbKjd0JKlA5iWtwSrjWfdNSe9PnvZQvzEIXg12voJVttZ+u7DaBmqyYpQz9alik/45r x7rHd6dNLZGUcGuMEwI4Ahf3+6iVcVj2o8XE/VGS1WKXxkUILyEEsBFsYEideqC0Cd3m r2Mw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=EROhCJAC; dkim=pass header.i=@codeaurora.org header.s=default header.b=GrAIKC/i; spf=pass (google.com: domain of poza@codeaurora.org designates 198.145.29.96 as permitted sender) smtp.mailfrom=poza@codeaurora.org Authentication-Results: mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=EROhCJAC; dkim=pass header.i=@codeaurora.org header.s=default header.b=GrAIKC/i; spf=pass (google.com: domain of poza@codeaurora.org designates 198.145.29.96 as permitted sender) smtp.mailfrom=poza@codeaurora.org MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Date: Thu, 18 Jan 2018 23:30:01 +0530 From: poza@codeaurora.org To: Sinan Kaya Cc: Bjorn Helgaas , Philippe Ombredanne , Thomas Gleixner , Greg Kroah-Hartman , Kate Stewart , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Dongdong Liu , Keith Busch , Wei Zhang , Timur Tabi Subject: Re: [PATCH v5 3/4] PCI/DPC: Unify and plumb error handling into DPC In-Reply-To: <35a9ce2b-156f-3235-c3b7-2c495fe9c52b@codeaurora.org> References: <1516185438-31556-1-git-send-email-poza@codeaurora.org> <1516185438-31556-4-git-send-email-poza@codeaurora.org> <733abfcb-5b31-7394-ab62-19a0888d71c2@codeaurora.org> <5cf7004e62a2979afb3c29e99d705c60@codeaurora.org> <35a9ce2b-156f-3235-c3b7-2c495fe9c52b@codeaurora.org> Message-ID: <64127dba1cebab196c88a160191ebee0@codeaurora.org> User-Agent: Roundcube Webmail/1.2.5 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: =?utf-8?q?1589835690475100377?= X-GMAIL-MSGID: =?utf-8?q?1589954114626882306?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: On 2018-01-18 22:01, Sinan Kaya wrote: > On 1/18/2018 12:57 AM, poza@codeaurora.org wrote: >> On 2018-01-18 10:47, poza@codeaurora.org wrote: >>> On 2018-01-17 22:16, Sinan Kaya wrote: >>>> On 1/17/2018 5:37 AM, Oza Pawandeep wrote: >>>>> +++ b/include/linux/dpc.h >>>>> @@ -0,0 +1,9 @@ >>>>> +/* SPDX-License-Identifier: GPL-2.0 */ >>>>> + >>>>> +#ifndef _DPC_H_ >>>>> +#define _DPC_H_ >>>>> + >>>>> +#define DPC_FATAL        4 >>>>> + >>>>> +#endif //_DPC_H_ >>>>> + >>>> >>>> can you keep this in drivers/pci.h and get rid of this file? >>> >>> I thought about this, but if I keep it in drivers/pci.h, >>> then AER's defines have to be in that as well. (for unification) >>> >>> and then all the dependent files who are using AER_FATAL such as >>> drivers/acpi/apei/ghees.c >>> have to go on including this drivers file which is odd way of doing >>> it. >>> >>> So I am not very sure about this....since AER_FATAL are in aer.h, I >>> have made dpc.h >>> >>> >>> Regards, >>> Oza. >> >> Should I be doing in next patch-set series ? >> > > I think you would put into include/linux/pci.h only if there is an > external > use of constant outside of drivers/pci directory. Otherwise, you should > keep > the setting inside one of the header files in drivers/pci directory. > > I don't see any other subsystem caring about DPC_FATAL definition. ok so you are suggesting to move only DPC_FATAL ? so then AER can stay where it is.