From: Arnd Bergmann <arnd@arndb.de>
To: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Cc: Bamvor Jian Zhang <bamvor.zhangjian@linaro.org>,
y2038@lists.linaro.org, gregkh@linuxfoundation.org,
broonie@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [Y2038] [PATCH v2 2/2] ppdev: add support for compat ioctl
Date: Thu, 31 Dec 2015 15:12:11 +0100 [thread overview]
Message-ID: <6416183.AAnzQivnkS@wuerfel> (raw)
In-Reply-To: <20151231094308.GA3489@sudip-pc>
On Thursday 31 December 2015 15:13:08 Sudip Mukherjee wrote:
> On Wed, Dec 30, 2015 at 10:20:58PM +0800, Bamvor Jian Zhang wrote:
> > On 12/30/2015 09:51 PM, Arnd Bergmann wrote:
> > > On Wednesday 30 December 2015 21:24:21 Bamvor Jian Zhang wrote:
> > >> diff --git a/drivers/char/ppdev.c b/drivers/char/ppdev.c
> > > This is something that would be caught by running 'make C=1' with 'sparse'
> > > on your patch. Can you try that to see if you introduce any other warnings?
> > OK. I do not do it before, there is no extra warning after apply the above
> > patch.
> > > I'm guessing it's fine, but it would be nice to confirm. I also send a lot
> > > of patches without running sparse and checkpatch first, but it's generally
> > > a good idea.
> > Got you. I only do the checkpatch in past. I will do sparse and checkpatch
> > in future.
>
> Usually sparse will be part of the tests that are done by 0day.
> Anyway, it worked perfectly in 64bit systems also. Can you please send
> your patch v3 with this change..
>
Ah, cool, thanks so much for testing.
Did you happen to check with both 32-bit and 64-bit user space on a
64-bit kernel? This is one of the things that was not working originally
but should work now.
Arnd
next prev parent reply other threads:[~2015-12-31 14:12 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-17 9:58 [PATCH v2 0/2] Convert ppdev to y2038 safe Bamvor Jian Zhang
2015-12-17 9:58 ` [PATCH v2 1/2] ppdev: convert " Bamvor Jian Zhang
2015-12-17 9:58 ` [PATCH v2 2/2] ppdev: add support for compat ioctl Bamvor Jian Zhang
2015-12-17 23:12 ` Arnd Bergmann
2015-12-30 11:16 ` Sudip Mukherjee
2015-12-30 13:24 ` Bamvor Jian Zhang
2015-12-30 13:48 ` Sudip Mukherjee
2015-12-30 13:51 ` [Y2038] " Arnd Bergmann
2015-12-30 14:20 ` Bamvor Jian Zhang
2015-12-31 9:43 ` Sudip Mukherjee
2015-12-31 14:12 ` Arnd Bergmann [this message]
2016-01-01 5:04 ` Sudip Mukherjee
2016-01-01 22:09 ` Arnd Bergmann
2016-01-02 6:29 ` Sudip Mukherjee
2016-01-02 22:40 ` Arnd Bergmann
2016-01-04 13:14 ` Sudip Mukherjee
2016-01-04 13:26 ` Arnd Bergmann
2016-01-06 12:56 ` Bamvor Jian Zhang
2016-01-07 15:12 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6416183.AAnzQivnkS@wuerfel \
--to=arnd@arndb.de \
--cc=bamvor.zhangjian@linaro.org \
--cc=broonie@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sudipm.mukherjee@gmail.com \
--cc=y2038@lists.linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox