From: "Colin King (gmail)" <colin.i.king@gmail.com>
To: Markus Elfring <Markus.Elfring@web.de>,
netdev@vger.kernel.org, kernel-janitors@vger.kernel.org,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
Lino Sanfilippo <LinoSanfilippo@gmx.de>,
Paolo Abeni <pabeni@redhat.com>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH next] net: ethernet: slicoss: remove redundant increment of pointer data
Date: Thu, 27 Jul 2023 18:15:19 +0100 [thread overview]
Message-ID: <64213517-099b-e5a7-6cf3-2f78fa59ee99@gmail.com> (raw)
In-Reply-To: <662ebbd2-b780-167d-ce57-cde1af636399@web.de>
On 26/07/2023 21:05, Markus Elfring wrote:
>> The pointer data is being incremented but this change to the pointer
>> is not used afterwards. The increment is redundant and can be removed.
>
> Are imperative change descriptions still preferred?
Hrm, I've used this style of commit message for a few thousand commits,
I hope it's still fine.
>
> See also:
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.5-rc3#n94
>
> Regards,
> Markus
next prev parent reply other threads:[~2023-07-27 17:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-26 16:45 [PATCH][next] net: ethernet: slicoss: remove redundant increment of pointer data Colin Ian King
2023-07-26 19:16 ` Lino Sanfilippo
[not found] ` <662ebbd2-b780-167d-ce57-cde1af636399@web.de>
2023-07-27 17:15 ` Colin King (gmail) [this message]
2023-07-28 23:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=64213517-099b-e5a7-6cf3-2f78fa59ee99@gmail.com \
--to=colin.i.king@gmail.com \
--cc=LinoSanfilippo@gmx.de \
--cc=Markus.Elfring@web.de \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox