Re: [PATCH v2 7/7] clk: ns2: add clock support for Broadcom Northstar 2 SoC

Jon Mason
2015-10-13T22:04:56Z

On Tue, Oct 13, 2015 at 11:18:53PM +0200, Arnd Bergmann wrote:
> On Tuesday 13 October 2015 17:08:05 Jon Mason wrote:
> > @@ -3,6 +3,7 @@ obj-$(CONFIG_CLK_BCM_KONA) += clk-kona-setup.o
> > obj-$(CONFIG_CLK_BCM_KONA) += clk-bcm281xx.o
> > obj-$(CONFIG_CLK_BCM_KONA) += clk-bcm21664.o
> > obj-$(CONFIG_COMMON_CLK_IPROC) += clk-iproc-armpll.o clk-iproc-pll.o clk-iproc-asiu.o
> > +obj-$(CONFIG_COMMON_CLK_IPROC) += clk-ns2.o
> > obj-$(CONFIG_ARCH_BCM_CYGNUS) += clk-cygnus.o
> > obj-$(CONFIG_ARCH_BCM_NSP) += clk-nsp.o
> > obj-$(CONFIG_ARCH_BCM_5301X) += clk-nsp.o
>
> If I understand this right, both CYGNUS and NS2 are IPROC based, but it
> looks like you now require building the clk-ns2 file for both?

There is no need for the NS2 clk code to be used by anything other
than NS2. There is no unique CONFIG_ identifier for NS2 in the code
that was accepted upstream. If I can add one for NS2, then I can
split this off similar to Cygnus or NSP. If not, then it has to be
lumped in with all of iProc. :(

> On a related note, I'm seeing problems when CONFIG_CYGNUS is set but
> CONFIG_COMMON_CLK_IPROC is disabled, as that currently leads to a link
> failure.

I can double check, but it should be on by default when Cygnus is
enabled. If you send me the error, I'll be happy to fix it.

Thanks,
Jon

>
> Arnd