From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CC14E328253 for ; Tue, 10 Feb 2026 12:11:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770725471; cv=none; b=c2yPW3026+Kj+6lxMNL7OpvHA9NGnqJFyaQQvmWkmuPbmjjpmU2zr9ft42vN7/F/6pBoYNDHivlIFy/X9CGT4D9zFiXNhkFcSu1DDrjVlo7VyyAMHgJRvfywE8YezLXH0Hq76dlTVIyyCH/p5h0s4m5z/H3mU+2H8Oty2DhGSvU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770725471; c=relaxed/simple; bh=aIqgcOyS2tGSkldTfhyJtvf2YJyfVC7eBzUOKbqnd8E=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=d6tQSbxMisDw6jVB/q04H4QQgkLJjku9Q9bWAEionOiEjLsUCfNzip5VyQO379U8lSrITQnEyU/YY80afhQHslVZvorueoMSfXfw8+9OnTQ+pOLB94Q24M0rLievBgZczgN4lpZS362sIXOvf9ODfC4oZhbtEpkqlJDrY6NIxms= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=QjPl3HJn; arc=none smtp.client-ip=209.85.128.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="QjPl3HJn" Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-47ee3a63300so9084045e9.2 for ; Tue, 10 Feb 2026 04:11:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770725467; x=1771330267; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=L/aBGhVtAGcnR8udEv0fvW2/wHXLRgg8jTfhj8B88qc=; b=QjPl3HJnbqeRlKqr485cm2XKVEXxJWPeVqbk6D3aQYAIQncunUpxxArPOz4xl+WZnW DlAZOpMoAZceaLNAkB0olPI5vEydEYQXzgLy06LpDa7xYaOLwITALpXXwVA2Cir4ol0i /HLCSf1Q+A9ozMxAI1+/sau31ioSNJ291NophWKWuemkdFqAg7E1AGadjJZwXPRR4R4F RnH7rZPIKBihcJmNznoQkUPk3D9hqWAXoYhaGwxBUm8U7brv4L64ldcZvhm4rBYdtEUM WCFm7YPzLltNCH5JB2KJ2GAe4ZdUoPXvV0z/9llPiuRb4B2OW2m5RpW9BckI1KsMO42R OQPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770725467; x=1771330267; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=L/aBGhVtAGcnR8udEv0fvW2/wHXLRgg8jTfhj8B88qc=; b=YJRs+zNHim02PLgiM8soElsldNoAjS4ocQDiQrKNvI1vpzAyPaBwpw0wZOMeOvLI2h wG784bUpPLcIwERrhwduGZE2RoE4amIt8slyzAYfOvNdQQfy74bWgy6EnMY7van25vWi oHDpsMhnmY9RKHkxkKcyHxIiacxURi98E5L9aXW2yLn1gBY2MCzEmMM0ryiUcnOfXAc2 T0BjOIvt+bA+qEsPort93qHHOjAKY0oJsWtnxSWSMV/2mYoCZilPegVbw+41da8M2l8D SJc2+4LCGKVaC/mfAeNql3NDysBJCn9B/don/jjWcFpBJm+jV7QDC5BSq1w9k0vqwS4b HGRw== X-Forwarded-Encrypted: i=1; AJvYcCUOlTkN3jJ1BceAzoaiIAjGpXJoA0L0CjPa44Z2Co626WWXJINVOTmfqIZaoR4wsFvoeQkIo/9p0cvOc1s=@vger.kernel.org X-Gm-Message-State: AOJu0YwqbJNVObI4VmvT/W69ZDmJtWy5edkVo2eWVhlcMt4QnGsGcxCp JZEiviPseliGF9/l794KZYk/8msB6uxvgmyPu7q5l8rXd7iodO4D/bi6 X-Gm-Gg: AZuq6aJCo0qtQ7QVhojgGSKfycsq65oUH+fry1FXTOea+AnZmErknFynfNgn5QwPR7D dEw4tHxnSQUVBJ+Dr/uYhImFidzaDfaH+t8OrTwW3MO1Df8vS+U9WZY7y7RiLt/EfuKbk50EnVS bi67Gz/CJfZLgP2Iim6NEJKhDAz1qkdxifJXD10kdlR0VAEdA2hy+dVPoVpHXOY5d8FQPvArTPa 88ZcCYPwRF4LagKw/E8Q+smN2Ew8xARMJazwBM+0RU12T+b5NWJGVGljoLvGfGnHu7N8LgScNrc 1OqXPoHrVcDoDmJVSSdMPaworO7RAURkT8Hh6LbS9ZrlEsVspJD+EtGs0sHzMfTWbeCiDWTv/Ba Xgcb0p359Cs5PGmWUaqfB1oWbrHwipwelR8PcDfGvPf4Otv28THfldtJx8diFauNVZlAXFFqtXr 9bkTeh9IrvP5bKA9baG1RnLzaIedgQrBA= X-Received: by 2002:a05:600c:3e87:b0:477:76c2:49c9 with SMTP id 5b1f17b1804b1-4832020025bmr203712055e9.2.1770725466921; Tue, 10 Feb 2026 04:11:06 -0800 (PST) Received: from [192.168.1.187] ([148.63.225.166]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48320961505sm229682495e9.4.2026.02.10.04.11.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Feb 2026 04:11:06 -0800 (PST) Message-ID: <642f9ed3c426ecfff250b9d00dd822c595e0fdfd.camel@gmail.com> Subject: Re: [PATCH v7 5/6] iio: adc: ad9467: simplify device pointer in probe From: Nuno =?ISO-8859-1?Q?S=E1?= To: Tomas Melin , Michael Hennerich , Nuno Sa , Lars-Peter Clausen , Jonathan Cameron , David Lechner , Andy Shevchenko , Olivier Moysan Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Andy Shevchenko Date: Tue, 10 Feb 2026 12:11:49 +0000 In-Reply-To: <20260210-b4-ad9467-optional-backend-v7-5-7a590ffe02df@vaisala.com> References: <20260210-b4-ad9467-optional-backend-v7-0-7a590ffe02df@vaisala.com> <20260210-b4-ad9467-optional-backend-v7-5-7a590ffe02df@vaisala.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.58.2 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Tue, 2026-02-10 at 10:53 +0000, Tomas Melin wrote: > Create alias for the device pointer to simplify referencing > and keeping syntax and column width shorter. >=20 > Suggested-by: Andy Shevchenko > Signed-off-by: Tomas Melin > --- Reviewed-by: Nuno S=C3=A1 > =C2=A0drivers/iio/adc/ad9467.c | 19 ++++++++++--------- > =C2=A01 file changed, 10 insertions(+), 9 deletions(-) >=20 > diff --git a/drivers/iio/adc/ad9467.c b/drivers/iio/adc/ad9467.c > index 59c3fa3bcc9b..ae9139290c22 100644 > --- a/drivers/iio/adc/ad9467.c > +++ b/drivers/iio/adc/ad9467.c > @@ -1283,12 +1283,13 @@ static void ad9467_debugfs_init(struct iio_dev *i= ndio_dev) > =C2=A0 > =C2=A0static int ad9467_probe(struct spi_device *spi) > =C2=A0{ > + struct device *dev =3D &spi->dev; > =C2=A0 struct iio_dev *indio_dev; > =C2=A0 struct ad9467_state *st; > =C2=A0 unsigned int id; > =C2=A0 int ret; > =C2=A0 > - indio_dev =3D devm_iio_device_alloc(&spi->dev, sizeof(*st)); > + indio_dev =3D devm_iio_device_alloc(dev, sizeof(*st)); > =C2=A0 if (!indio_dev) > =C2=A0 return -ENOMEM; > =C2=A0 > @@ -1303,16 +1304,16 @@ static int ad9467_probe(struct spi_device *spi) > =C2=A0 if (AD9467_CAN_INVERT(st)) > =C2=A0 st->calib_map_size *=3D 2; > =C2=A0 > - st->clk =3D devm_clk_get_enabled(&spi->dev, "adc-clk"); > + st->clk =3D devm_clk_get_enabled(dev, "adc-clk"); > =C2=A0 if (IS_ERR(st->clk)) > =C2=A0 return PTR_ERR(st->clk); > =C2=A0 > - st->pwrdown_gpio =3D devm_gpiod_get_optional(&spi->dev, "powerdown", > + st->pwrdown_gpio =3D devm_gpiod_get_optional(dev, "powerdown", > =C2=A0 =C2=A0=C2=A0 GPIOD_OUT_LOW); > =C2=A0 if (IS_ERR(st->pwrdown_gpio)) > =C2=A0 return PTR_ERR(st->pwrdown_gpio); > =C2=A0 > - ret =3D ad9467_reset(&spi->dev); > + ret =3D ad9467_reset(dev); > =C2=A0 if (ret) > =C2=A0 return ret; > =C2=A0 > @@ -1322,8 +1323,8 @@ static int ad9467_probe(struct spi_device *spi) > =C2=A0 > =C2=A0 id =3D ad9467_spi_read(st, AN877_ADC_REG_CHIP_ID); > =C2=A0 if (id !=3D st->info->id) { > - dev_err(&spi->dev, "Mismatch CHIP_ID, got 0x%X, expected 0x%X\n", > - id, st->info->id); > + dev_err(dev, "Mismatch CHIP_ID, got 0x%X, expected 0x%X\n", id, > + st->info->id); > =C2=A0 return -ENODEV; > =C2=A0 } > =C2=A0 > @@ -1339,11 +1340,11 @@ static int ad9467_probe(struct spi_device *spi) > =C2=A0 if (ret) > =C2=A0 return ret; > =C2=A0 > - ret =3D devm_iio_backend_request_buffer(&spi->dev, st->back, indio_dev)= ; > + ret =3D devm_iio_backend_request_buffer(dev, st->back, indio_dev); > =C2=A0 if (ret) > =C2=A0 return ret; > =C2=A0 > - ret =3D devm_iio_backend_enable(&spi->dev, st->back); > + ret =3D devm_iio_backend_enable(dev, st->back); > =C2=A0 if (ret) > =C2=A0 return ret; > =C2=A0 > @@ -1351,7 +1352,7 @@ static int ad9467_probe(struct spi_device *spi) > =C2=A0 if (ret) > =C2=A0 return ret; > =C2=A0 > - ret =3D devm_iio_device_register(&spi->dev, indio_dev); > + ret =3D devm_iio_device_register(dev, indio_dev); > =C2=A0 if (ret) > =C2=A0 return ret; > =C2=A0