From: Tony Nguyen <anthony.l.nguyen@intel.com>
To: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>,
<jesse.brandeburg@intel.com>
Cc: <davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>,
<pabeni@redhat.com>, <intel-wired-lan@lists.osuosl.org>,
<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
Abaci Robot <abaci@linux.alibaba.com>
Subject: Re: [PATCH] iavf: Remove useless else if
Date: Mon, 12 Sep 2022 15:01:21 -0700 [thread overview]
Message-ID: <6445a450-d15f-be32-818a-4bb1c11ef429@intel.com> (raw)
In-Reply-To: <20220909033240.46329-1-jiapeng.chong@linux.alibaba.com>
On 9/8/2022 8:32 PM, Jiapeng Chong wrote:
> The assignment of the else and else if branches is the same, so the else
> if here is redundant, so we remove it and add a comment to make the code
> here readable.
>
> ./drivers/net/ethernet/intel/iavf/iavf_main.c:2211:6-8: WARNING: possible condition with no effect (if == else).
This was already nacked by Jakub [1].
Thanks,
Tony
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2106
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
[1] https://lore.kernel.org/netdev/20220801091355.6ca23bcf@kernel.org/
next prev parent reply other threads:[~2022-09-12 22:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-09 3:32 [PATCH] iavf: Remove useless else if Jiapeng Chong
2022-09-12 22:01 ` Tony Nguyen [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-05-19 8:38 Jiapeng Chong
2023-05-19 11:54 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6445a450-d15f-be32-818a-4bb1c11ef429@intel.com \
--to=anthony.l.nguyen@intel.com \
--cc=abaci@linux.alibaba.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jesse.brandeburg@intel.com \
--cc=jiapeng.chong@linux.alibaba.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox