linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Yisheng Xie <xieyisheng1@huawei.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Greg KH <gregkh@linuxfoundation.org>, <ysxie@foxmail.com>,
	<linux-gpio@vger.kernel.org>
Subject: Re: [PATCH v3 18/27] pinctrl: replace devm_ioremap_nocache with devm_ioremap
Date: Wed, 3 Jan 2018 14:15:36 +0800	[thread overview]
Message-ID: <644fa45e-d06c-458b-464f-bd5312cc33b0@huawei.com> (raw)
In-Reply-To: <CACRpkdaZ5HRC-Mhc=apRSXwizf_8b8ioLfg_=VN5b-eGYJGADQ@mail.gmail.com>



On 2018/1/2 16:43, Linus Walleij wrote:
> On Sat, Dec 23, 2017 at 12:00 PM, Yisheng Xie <xieyisheng1@huawei.com> wrote:
> 
>> Default ioremap is ioremap_nocache, so devm_ioremap has the same
>> function with devm_ioremap_nocache, which can just be killed to
>> save the size of devres.o
>>
>> This patch is to use use devm_ioremap instead of devm_ioremap_nocache,
>> which should not have any function change but prepare for killing
>> devm_ioremap_nocache.
>>
>> Cc: Linus Walleij <linus.walleij@linaro.org>
>> Cc: linux-gpio@vger.kernel.org
>> Signed-off-by: Yisheng Xie <xieyisheng1@huawei.com>
> 
> Patch applied.

Well, I list the ARCHs related to the change file, do not include cris,ia64,mn10300
and openrisc, which ioremap is not the same as ioremap_nocache, as discussed in cover
letter. So please let me know if I need update the comment.

 change file							ARCH
 drivers/pinctrl/bcm/pinctrl-ns2-mux.c         | 2 +-		arm/arm64
 drivers/pinctrl/bcm/pinctrl-nsp-mux.c         | 4 ++--		arm
 drivers/pinctrl/freescale/pinctrl-imx1-core.c | 2 +-		arm
 drivers/pinctrl/pinctrl-amd.c                 | 4 ++--		x86/arm

Thanks
Yisheng
> 
> Yours,
> Linus Walleij
> 
> 

  reply	other threads:[~2018-01-03  6:15 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-23 11:00 [PATCH v3 18/27] pinctrl: replace devm_ioremap_nocache with devm_ioremap Yisheng Xie
2018-01-02  8:43 ` Linus Walleij
2018-01-03  6:15   ` Yisheng Xie [this message]
2018-01-03  7:49     ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=644fa45e-d06c-458b-464f-bd5312cc33b0@huawei.com \
    --to=xieyisheng1@huawei.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ysxie@foxmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).