From: Mukesh Ojha <mojha@codeaurora.org>
To: Borislav Petkov <bp@alien8.de>, LKML <linux-kernel@vger.kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Valentin Schneider <valentin.schneider@arm.com>,
Frederic Weisbecker <fweisbec@gmail.com>,
x86@kernel.org
Subject: Re: [PATCH] tick/broadcast: Fix warning about undefined tick_broadcast_oneshot_offline()
Date: Fri, 29 Mar 2019 18:14:28 +0530 [thread overview]
Message-ID: <6451ced9-1e65-d146-ac9b-a83f32c97685@codeaurora.org> (raw)
In-Reply-To: <20190329110508.6621-1-bp@alien8.de>
On 3/29/2019 4:35 PM, Borislav Petkov wrote:
> From: Borislav Petkov <bp@suse.de>
>
> Randconfig builds with
>
> CONFIG_TICK_ONESHOT=y
> CONFIG_HOTPLUG_CPU=n
>
> trigger
>
> kernel/time/tick-broadcast.c:39:13: warning: ‘tick_broadcast_oneshot_offline’ \
> declared ‘static’ but never defined [-Wunused-function]
>
> due to that function's definition missing.
>
> Move the CONFIG_HOTPLUG_CPU ifdeffery around its declaration too.
>
> Fixes: 1b72d4323798 ("tick: Remove outgoing CPU from broadcast masks")
> Signed-off-by: Borislav Petkov <bp@suse.de>
> Acked-by: Thomas Gleixner <tglx@linutronix.de>
> Cc: Valentin Schneider <valentin.schneider@arm.com>
> Cc: Frederic Weisbecker <fweisbec@gmail.com>
> Cc: x86@kernel.org
Reviewed-by: Mukesh Ojha <mojha@codeaurora.org>
Cheers,
-Mukesh
> ---
> kernel/time/tick-broadcast.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/kernel/time/tick-broadcast.c b/kernel/time/tick-broadcast.c
> index 0283523de045..7541cbca695e 100644
> --- a/kernel/time/tick-broadcast.c
> +++ b/kernel/time/tick-broadcast.c
> @@ -36,12 +36,16 @@ static __cacheline_aligned_in_smp DEFINE_RAW_SPINLOCK(tick_broadcast_lock);
> static void tick_broadcast_setup_oneshot(struct clock_event_device *bc);
> static void tick_broadcast_clear_oneshot(int cpu);
> static void tick_resume_broadcast_oneshot(struct clock_event_device *bc);
> +# ifdef CONFIG_HOTPLUG_CPU
> static void tick_broadcast_oneshot_offline(unsigned int cpu);
> +# endif
> #else
> static inline void tick_broadcast_setup_oneshot(struct clock_event_device *bc) { BUG(); }
> static inline void tick_broadcast_clear_oneshot(int cpu) { }
> static inline void tick_resume_broadcast_oneshot(struct clock_event_device *bc) { }
> +# ifdef CONFIG_HOTPLUG_CPU
> static inline void tick_broadcast_oneshot_offline(unsigned int cpu) { }
> +# endif
> #endif
>
> /*
next prev parent reply other threads:[~2019-03-29 12:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-29 11:05 [PATCH] tick/broadcast: Fix warning about undefined tick_broadcast_oneshot_offline() Borislav Petkov
2019-03-29 12:44 ` Mukesh Ojha [this message]
2019-03-29 13:19 ` [tip:timers/core] " tip-bot for Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6451ced9-1e65-d146-ac9b-a83f32c97685@codeaurora.org \
--to=mojha@codeaurora.org \
--cc=bp@alien8.de \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=valentin.schneider@arm.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox