Re: [PATCH 1/3] char: lp: ensure that index has not exceeded LP_NO

[Shreenidhi Shedi <yesshedi@gmail.com>]

On 15/05/22 1:24 pm, Shreenidhi Shedi wrote:
> After finishing the loop, index value can be equal to LP_NO and lp_table
> array is of size LP_NO, so this can end up in accessing an out of bound
> address in lp_register function.
> 
> Signed-off-by: Shreenidhi Shedi <sshedi@vmware.com>
> ---
>  drivers/char/lp.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/char/lp.c b/drivers/char/lp.c
> index bd95aba1f..e61060f3c 100644
> --- a/drivers/char/lp.c
> +++ b/drivers/char/lp.c
> @@ -971,7 +971,7 @@ static void lp_attach(struct parport *port)
>  			if (port_num[i] == -1)
>  				break;
>  
> -		if (!lp_register(i, port))
> +		if (i < LP_NO && !lp_register(i, port))
>  			lp_count++;
>  		break;
>  

Hi Greg and Arnd Bergmann,

Please review the above changes. Ignore second patch.

--
Shedi