public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Denis Benato <denis.benato@linux.dev>
To: Armandas Kvietkus <armundunelis@gmail.com>, luke@ljones.dev
Cc: hansg@kernel.org, ilpo.jarvinen@linux.intel.com,
	platform-driver-x86@vger.kernel.org,
	linux-kernel@vger.kernel.org, fxzxaxon@outlook.com
Subject: Re: [PATCH] platform/x86: asus-armoury: downgrade missing power limits warning to debug
Date: Mon, 4 May 2026 00:14:07 +0200	[thread overview]
Message-ID: <6460ef7c-b4d9-4106-95cc-35710b4798bb@linux.dev> (raw)
In-Reply-To: <20260503175734.27795-1-armundunelis@gmail.com>


On 5/3/26 19:57, Armandas Kvietkus wrote:
> When a system is not found in the power_limits DMI table,
> init_rog_tunables() emits a pr_warn() and returns. This is
> expected behaviour for hardware that does not support ROG
> power limit tunables, not an error condition.
>
> Downgrade to pr_debug() to avoid spurious boot noise on
> unsupported systems while preserving the message for debugging.
>
> Reported-by: fxzxaxon@outlook.com
> Closes: https://bugzilla.kernel.org/show_bug.cgi?id=221441
> Signed-off-by: Armandas Kvietkus <armundunelis@gmail.com>
> ---
>  drivers/platform/x86/asus-armoury.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/asus-armoury.c b/drivers/platform/x86/asus-armoury.c
> index 5b0987ccc..c8e9ff89f 100644
> --- a/drivers/platform/x86/asus-armoury.c
> +++ b/drivers/platform/x86/asus-armoury.c
> @@ -991,7 +991,7 @@ static void init_rog_tunables(void)
>  	/* Match the system against the power_limits table */
>  	dmi_id = dmi_first_match(power_limits);
>  	if (!dmi_id) {
> -		pr_warn("No matching power limits found for this system\n");
> +		pr_debug("No matching power limits found for this system\n");
Maybe this is right to get downgraded, but still no debug: I think info is better,
but I would like to hear from Luke what this is about.

Denis
>  		return;
>  	}
>  

      parent reply	other threads:[~2026-05-03 22:14 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-03 17:57 [PATCH] platform/x86: asus-armoury: downgrade missing power limits warning to debug Armandas Kvietkus
2026-05-03 21:23 ` Denis Benato
2026-05-03 22:14 ` Denis Benato [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6460ef7c-b4d9-4106-95cc-35710b4798bb@linux.dev \
    --to=denis.benato@linux.dev \
    --cc=armundunelis@gmail.com \
    --cc=fxzxaxon@outlook.com \
    --cc=hansg@kernel.org \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luke@ljones.dev \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox