From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754524AbdHYDGr (ORCPT ); Thu, 24 Aug 2017 23:06:47 -0400 Received: from mail-oi0-f46.google.com ([209.85.218.46]:34912 "EHLO mail-oi0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754499AbdHYDGq (ORCPT ); Thu, 24 Aug 2017 23:06:46 -0400 Subject: Re: [PATCH net-next] e1000e: Be drop monitor friendly To: netdev@vger.kernel.org Cc: edumazet@gmail.com, davem@davemloft.net, Jeff Kirsher , "moderated list:INTEL ETHERNET DRIVERS" , open list References: <20170825013650.27463-1-f.fainelli@gmail.com> From: Florian Fainelli Message-ID: <6475bbf2-9035-5630-e03e-66c2fdf1af0d@gmail.com> Date: Thu, 24 Aug 2017 20:06:42 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170825013650.27463-1-f.fainelli@gmail.com> Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/24/2017 06:36 PM, Florian Fainelli wrote: > e1000_put_txbuf() cleans up the successfully transmitted TX packets, > e1000e_tx_hwtstamp_work() also does the successfully completes the > timestamped TX packets, e1000_clean_rx_ring() cleans up the RX ring and > e1000_remove() cleans up the timestampted packets. None of these > functions should be reporting dropped packets, so make them use > dev_consume_skb*() to be drop monitor friendly. This also won't compile, I marked it a Superseded in patchwork since there is a v2 coming. -- Florian