From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752651AbcEDOXd (ORCPT ); Wed, 4 May 2016 10:23:33 -0400 Received: from mout.kundenserver.de ([217.72.192.73]:58755 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750846AbcEDOXb (ORCPT ); Wed, 4 May 2016 10:23:31 -0400 From: Arnd Bergmann To: Saeed Mahameed Cc: Matan Barak , Leon Romanovsky , Saeed Mahameed , Linux Netdev List , linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, "David S. Miller" , Matthew Finlay , Richard Cochran , Amir Vadai , Haggai Abramonvsky , Maor Gottlieb , Or Gerlitz , Majd Dibbiny Subject: Re: [PATCH 3/3] net/mlx5e: don't build RFS without ethernet Date: Wed, 04 May 2016 16:23:19 +0200 Message-ID: <6481938.m1ihicFdKr@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: References: <1462364774-3792510-1-git-send-email-arnd@arndb.de> <1462365155-3861405-1-git-send-email-arnd@arndb.de> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:8MNgygfqsFMNTF4UJMEBuCBp9XA4He21bmDWkyelhjInUsQ2Gqs elxWZhcehNWr9HOklQ+++8IxCT/URya6sX7GH/g1jWukyzdZ3XWASZtVvVFJUzsa79Jv3hW 2ahO6B2EY0tmdiqZdLlbB9N3P7PkAt14hxAEMpkKpCxWXgMUv4Qxm25RaTvnJ6gmjus6jpn GuBnr4wKuzMgIrb+i+iQA== X-UI-Out-Filterresults: notjunk:1;V01:K0:9zCEgEnj5A4=:cm/I/62iBaju/2M1GCWgL9 SY0RVtrpRzv6BmrbNwMB9nql1/RuFtycVPDg8H/7TXdhRNUWALYxAkcVX8H4Nm0dApB070l7f H2XmUHkF94F/5FwjoaOlrZnslgmT1Bz+yEPKNaxe6o6WjJC3oXGmEmRynlf4k9aJbR9jPJ9Fi JlarW0tGLr0zxhXdovKiSc6yItO/jjQb5tPDILOuG1wMrZW4s4L4IuONb4zWgpmUWyPxYxXg8 NbBEcfSlrDaN9ZgXLBmRc+AgcHlDwaXZLXkuIMgbwC22O7P/uNi03skK/QvKcc9fpa6dE59uB 7Fa9r3UeOEYP7R5T4uuN1LrI2LbqznxkVsBM8DkAhBrcSKv08/DFnOHsQoG2yhRP4OxDwlTsj axTZh1MldjsjQ6GVTob5JFHOJrFY7I33HyC8078vjHMYc+Xk9cjqXukmBfTl444p1I4MFJ3SZ /YQnw/+kiaWDn2SS9bUq9snECpqZvTWXkEygwWGdukz5SAv8I7Cgh7Vgj4xWOMv83Bwsc+SF2 gMEN4JnYMWvbsVXwpMQmdHEOsrtH3aLziSEs51lhjs7QgMC7lqkUfeJh/mi8OJnQJPpCIXN22 9zZ39580e5TQ0hGtKxh005g9IJr8fb+0KTmCxjVK9JAYaNBOaplsuzYgmpS2hautS+KZ+dXu3 E/aONdD1WalGTcrlnlxg40UsHr+O7BboBxPfHFs8sc64d7BNMQR33DS7PXDKzPk8QIXxnn+Lh MzM77z/Mqug51kpE Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday 04 May 2016 16:09:16 Saeed Mahameed wrote: > On Wed, May 4, 2016 at 3:32 PM, Arnd Bergmann wrote: > > The RFS acceleration support in mlx5 is enabled whenever CONFIG_RFS_ACCEL > > is in use. However, this fails if a user turns off CONFIG_MLX5_CORE_EN, > > because the rfs code now calls into the ethernet portion of the > > driver: > > > > ERROR: "mlx5e_destroy_flow_table" [drivers/net/ethernet/mellanox/mlx5/core/mlx5_core.ko] undefined! > > > > Hi Arnd, > > We already posted a fix for this, please see "[PATCH net-next V1 > 01/12] net/mlx5e: Fix aRFS compilation dependency", and give us your > feedback. That version looks fine as well. I think it's better to be a little more explicit as I was, but either way seems fine. You can also achieve the same thing in yet another way using Makefile syntax instead of cpp or Kconfig: ifdef CONFIG_MLX5_CORE_EN mlx5_core-y += wq.o eswitch.o \ en_main.o en_fs.o en_ethtool.o en_tx.o en_rx.o \ en_txrx.o en_clock.o vxlan.o en_tc.o en_txrx.o en_clock.o vxlan.o en_tc.o en_arfs.o mlx5_core-$(CONFIG_RFS_ACCEL) += en_arfs.o endif If you prefer Maor's version, feel free to add Acked-by: Arnd Bergmann Arnd