From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753005AbbJMLjK (ORCPT ); Tue, 13 Oct 2015 07:39:10 -0400 Received: from mout.kundenserver.de ([212.227.126.130]:62543 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752073AbbJMLjI (ORCPT ); Tue, 13 Oct 2015 07:39:08 -0400 From: Arnd Bergmann To: Alim Akhtar Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, JBottomley@odin.com, vinholikatti@gmail.com, amit.daniel@samsung.com, essuuj@gmail.com, devicetree@vger.kernel.org Subject: Re: [PATCH v3 12/13] scsi: ufs-exynos: add UFS host support for Exynos SoCs Date: Tue, 13 Oct 2015 13:38:52 +0200 Message-ID: <6499659.hVBcEphJIR@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <561CE8CB.9010102@samsung.com> References: <1443686970-28104-1-git-send-email-alim.akhtar@samsung.com> <2228323.jdbqnSKW75@wuerfel> <561CE8CB.9010102@samsung.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:azFXXbdVAJmFrKoUerrfixdYTDlx0JgKSciSfJYSac1L9Dv4Siq 80aWsFzq/4bLrVznz1Ghr9KmN81/6jShJnPSAR5UoAqeK/3lTch7vTG2KhQte/NL8VyM900 00Pdxia7W8s3+XGiUlsvb2EDacm01pmC4mZHtKC+ptd+BnRCOkcdQnTAtolBl0fJJ1aGPdh Wg6Gp/Ww9wEqHMkgy8fng== X-UI-Out-Filterresults: notjunk:1;V01:K0:Tgei51cgzQ4=:/ENQrR4h7qQj9G6tAZ7CjW WKlcbwPB4gDHYvf1ZMBPxFEozjjqk3lgaOCp/+eW+iOvwxq4cPkFVija6ZRWgViaLtcC/P5UH 0bTLb/GO+NPtFxQntjtDsbv0FfkcDnceFD9zgUlthasd+iVcDHx7qVL0GNgIAdNrMBPTHfE/Q 7pEbWKDDXMJpqfYuMC3copUo7ZUYEX3YWihC4uTMKZj2kzf/HjKQz1MEGkFzVgk2al0RDZrf9 DF9NGyUiZYUCKLGQi1AgV55uVvZARHbLHx/weJaydvcMuBhXR7MB2MeAq+e1mdqKwxJlw3rgB IFPsJh4Vc/ToymDuss0PPfyTn0fQPPmddxdzeOaRevUA8nwCNiev9GMQsMlrvHaeBrTm+TB1C tD7R5mu1gCe0Jnn+F3eXEHVehBG/fiTP6FoWsI45GE8Nu6H2wVzmvFrObn36LwgykCA7wRk6N slojvCYc4xF/D8zMyMiCfwvzTRkac9G++k3Nul4c7Ll4yvZZycuy78E3cyCBZDCRK4u2TWlm9 uomSEeMBL7VVsXxLBF3XVlb1OI0w0xVMZvQ+ws5QioGUoXkGoGSsfmbIOqYTjkmKdrby6DjqR LiPajf339JspHyQFPz0FeAgV/1kDsbtbUUuNHKlDjS9wfGqYW9AnANuQcsOIUJJuyhALFuGci NY69Kd5yGOOF6BHsULLRmFrAFOLenqa5RLUomCLep5CWOEjRjVKFOW+VFLtLbzeXKlAUp8/bT 8SDkOBKWDPfqcc28 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday 13 October 2015 16:49:39 Alim Akhtar wrote: > >> diff --git a/drivers/scsi/ufs/ufs-exynos.h b/drivers/scsi/ufs/ufs-exynos.h > >> new file mode 100644 > >> index 0000000..58aa714 > >> --- /dev/null > >> +++ b/drivers/scsi/ufs/ufs-exynos.h > >> @@ -0,0 +1,463 @@ > >> +/* > >> + * UFS Host Controller driver for Exynos specific extensions > >> + * > >> + * Copyright (C) 2014-2015 Samsung Electronics Co., Ltd. > >> + * > >> + * This program is free software; you can redistribute it and/or modify > >> + * it under the terms of the GNU General Public License as published by > >> + * the Free Software Foundation; either version 2 of the License, or > >> + * (at your option) any later version. > >> + */ > >> + > >> +#ifndef _UFS_EXYNOS_H_ > >> +#define _UFS_EXYNOS_H_ > > > > You have a lot of things in this header that are only used in one of the > > .c files, so just move them there and make the header as small as possible. > > > hmm..these are mostly the registers defines, will removes the one which > are not being used as of now. > Do you think I should sill move them to .c file? > Yes. No need to remove the unused register definitions, just don't put them into a separate header if they are only used in one place. Arnd