From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 240D13E1230 for ; Mon, 6 Jul 2026 11:07:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783336064; cv=none; b=dQgbrmpHGUhnXLnmQYhv78YBOhCfvLaNvn5sGdPBzvnddgpVl09/S3TKJA4+Wl9Z4XQ6hCAgrnCDHp0r6S6o7xyhxouh6asBe1lBtaEz2XRYrbA0qbO4mZsVhn3v7OaqPFlkd0h8XiXLq+7v6fcT0i7iO0rzVKJxa10Q9r1ZRa8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783336064; c=relaxed/simple; bh=Pb7Xc1kKgr/AtADErH7EMWnxZPWuIpL20gPg2uLqnAY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=L4EUQTBaZ+eJ40A2HGVMTpNigOdeW7yfdom6CRgoPvtwI7wPsYgq5/7Zv2iMDOfsIXi0lRz0bC/NcxfuLP37VGrRzlRtCAVksCwAqjOd6ia0l//7jMYR+ABwj67cCoz3X6A3cDTW+GLnii7kl0WBI/TlP/PVsBw0GmCW8BnfRDA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=pe9Ac8NI; arc=none smtp.client-ip=209.85.128.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="pe9Ac8NI" Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-493c733f15aso29511845e9.0 for ; Mon, 06 Jul 2026 04:07:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783336060; x=1783940860; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=hwdEJkuxK+8pOC6TCcezbBHIneZ4lflSArjit6m0NnA=; b=pe9Ac8NIqGiPpeC9sFton1Q67L/6R1VAiAoK5n/+/gQKQPMabOHcOpEueYGw34Vm0X 1TSE97ST3V+7+Y4ga525HjMrBsf1Ajg97RURYOe17bY1YBJPSc4zpcCIaX4prMq12Q4F 7M9v+F1W37SXN9N8P/ot0D4eUU0xVZGtjd1GX5aOg7NroOopIFZBFMjJ6r6m/aEZ0yHB 2z+Jdn3Hylq4EzbVMDUWOJNC9AscxuFDmagxQb1GqRIl3lRWlh39t0uCR9UMvIZLMqDA sVyMvaeSPUimgnqrNkPJf+yx9ECDkEVteGotj3VkHc8653gyMPlwuFs2eMtoNsfSxiGM BTtQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783336060; x=1783940860; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=hwdEJkuxK+8pOC6TCcezbBHIneZ4lflSArjit6m0NnA=; b=dTLmj6f9bHW8nUM9iAVGgcxYMQvYY1+hD60VuGPH1u+MRKW+gq8x4Tm/QUZGtPh0v4 r5HxIKrtZpXC2DKrvinKnurC0G+19utorFIMeswxUpo2yrvkrGvL367UmiwY2I/p+uuo O8oFf0FoAbYSbq8bkIrVuPQc2Ln1MLTu/w4WbMWxfcYlkPK40BnjHNEC4SG5yYccIjaW qLcoBNoGmE9bUpz4DqToDd0hAaCYpM4s2NbAigjpR4o28N6T3hb3mUBmNZkmHFyXDAPJ 6boiDXbypdaZ/dIpP+aDixNa7+SEzH5DmpWGLBd1T8bgvojlxD0w9+pW8jnxAqQrEZAf sAZQ== X-Forwarded-Encrypted: i=1; AHgh+RoU/cRJp6QTmkLIHaIRfJQhy9DkScobT8MqVMRiDpUMik15t5e/bcb+Bqa+W5S8E3T5gZ4osEa3b7dQVV8=@vger.kernel.org X-Gm-Message-State: AOJu0YxleXdVj8pSt7d0NHqmHL5i8HEogR1fObF5C5zY0zVkPkGgHFLd Iy6YNKuDwmShjDZQ1v44l73AUUST4mTxXxKuw/skyXygsBEIgm0yabU= X-Gm-Gg: AfdE7cknmre6bqeg1tRrPr+HiB0GF+Nef/30+/1XXkNGn4ibjRhirZEi6sqgpsgCc44 C0yRvQX66RyIs8v15dmN+zFcYYTY9bJ7tA22IXwQqQO+vcfEz/+zl0qyijrc+SAtrfEQ4sbJ0Df L7CPRKTGOZW7PEGZEKnk0XRrCrLTZl+A1s3DRZD7WiOl5Qp7Ky3WGlMFie1mCOqQHu7n0LASmwM ql1yqAhDRQqDxAeAtz2C4P5GAvzegV7ykR1r/iz5qlqqHF9xaAlEsYC3z6/Vv5S9BcrqkaPxqsx DWKUk7Bm2yio9PvvscRmcM5cmWqtWoPfe8hA8Pj6pNX2Z8ZBsa6vM8KyXunvxYhzw251FGNZjBX /578SWQcMFCB8M49X8XSf1l/2e+AQitBMFIf1dpQR1+vaHVSaQkoD02P+bzMAdM6/etLvIHs9c7 FslZ0MZcptjoHYUTx/yyX6qR4+3gfTmEI8N+2lXdBLyQMA+cTTzbMES6TkEqnq4OPvKMUvVA== X-Received: by 2002:a05:600c:c16f:b0:492:523f:a3df with SMTP id 5b1f17b1804b1-493d52ac417mr90419125e9.5.1783336060307; Mon, 06 Jul 2026 04:07:40 -0700 (PDT) Received: from ?IPV6:2001:b07:2ec:601d:4b26:1672:75c7:805a? ([2001:b07:2ec:601d:4b26:1672:75c7:805a]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-493cce12c40sm463102745e9.13.2026.07.06.04.07.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 06 Jul 2026 04:07:39 -0700 (PDT) Message-ID: <64a919ab-8b36-45fe-8da8-5eaaf4d55359@gmail.com> Date: Mon, 6 Jul 2026 13:07:37 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFC 10/13] drm/msm: initialize LPAC ring To: Konrad Dybcio , Rob Clark , Will Deacon , Robin Murphy , Joerg Roedel , Sean Paul , Konrad Dybcio , Akhil P Oommen , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Marijn Suijten , David Airlie , Simona Vetter , Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann Cc: iommu@lists.linux.dev, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, devicetree@vger.kernel.org References: <20260705-descriptive-name-lpac-upstream-v1-0-01d50c3e0c99@gmail.com> <20260705-descriptive-name-lpac-upstream-v1-10-01d50c3e0c99@gmail.com> <93b78299-866f-4a3c-9423-a990d9a7d4cd@oss.qualcomm.com> Content-Language: en-US From: Anna Maniscalco In-Reply-To: <93b78299-866f-4a3c-9423-a990d9a7d4cd@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 7/6/26 10:44 AM, Konrad Dybcio wrote: > On 7/5/26 9:13 PM, Anna Maniscalco wrote: >> Program all the register needed to start up LPAC and send initialization >> sequence. >> >> Additionally, now that the LPAC ring is live, make the code aware of it. >> >> Signed-off-by: Anna Maniscalco >> --- > I believe some/all of these writes need to be guarded by if (has_lpac), > as many GPUs lack these registers and there may be side effects on > others That's correct yeah. I'm not sure what has_lpac should be though. Something we add to catalog? Or checking if it is a gen that has LPAC? > > > [...] > >> a6xx_gpu->shadow = msm_gem_kernel_new(gpu->dev, >> - sizeof(u32) * gpu->nr_rings, >> + sizeof(u32) * (gpu->nr_rings + !!gpu->lpac_rb), > Should we rename nr_rings to something like nr_XXX_rings > where XXX is some uarch-generic (i.e. not SQE because we also > support pre-a6xx) name for the main number cruncher? Qualcom calls it GC so nr_gc_rings perhaps? > > Konrad Best regards, -- Anna Maniscalco