From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753492AbdK1PmB (ORCPT <rfc822;w@1wt.eu>);
        Tue, 28 Nov 2017 10:42:01 -0500
Received: from esa4.microchip.iphmx.com ([68.232.154.123]:28670 "EHLO
        esa4.microchip.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1753200AbdK1PmA (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 28 Nov 2017 10:42:00 -0500
X-IronPort-AV: E=Sophos;i="5.43,434,1503385200"; 
   d="scan'208";a="8957252"
Subject: Re: [PATCH] pcmcia: at91_cf: Use PTR_ERR_OR_ZERO()
To: Vasyl Gomonovych <gomonovych@gmail.com>,
        <alexandre.belloni@free-electrons.com>,
        <linux-pcmcia@lists.infradead.org>,
        <linux-arm-kernel@lists.infradead.org>
CC: <linux-kernel@vger.kernel.org>
References: <1511882500-7285-1-git-send-email-gomonovych@gmail.com>
From: Nicolas Ferre <nicolas.ferre@microchip.com>
Organization: microchip
Message-ID: <64b581c0-059f-bdea-d661-bcbdd8d1d1a4@microchip.com>
Date: Tue, 28 Nov 2017 16:41:55 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.4.0
MIME-Version: 1.0
In-Reply-To: <1511882500-7285-1-git-send-email-gomonovych@gmail.com>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 28/11/2017 at 16:21, Vasyl Gomonovych wrote:
> Fix ptr_ret.cocci warnings:
> drivers/pcmcia/at91_cf.c:239:1-3: WARNING: PTR_ERR_OR_ZERO can be used
> 
> Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR
> 
> Generated by: scripts/coccinelle/api/ptr_ret.cocci
> 
> Signed-off-by: Vasyl Gomonovych <gomonovych@gmail.com>

okay...
Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>

> ---
>  drivers/pcmcia/at91_cf.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/pcmcia/at91_cf.c b/drivers/pcmcia/at91_cf.c
> index 87147bcd1655..7da7b0f0ae1b 100644
> --- a/drivers/pcmcia/at91_cf.c
> +++ b/drivers/pcmcia/at91_cf.c
> @@ -236,10 +236,8 @@ static int at91_cf_dt_init(struct platform_device *pdev)
>  	pdev->dev.platform_data = board;
>  
>  	mc = syscon_regmap_lookup_by_compatible("atmel,at91rm9200-sdramc");
> -	if (IS_ERR(mc))
> -		return PTR_ERR(mc);
>  
> -	return 0;
> +	return PTR_ERR_OR_ZERO(mc);
>  }
>  #else
>  static int at91_cf_dt_init(struct platform_device *pdev)
> 


-- 
Nicolas Ferre