From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AACA539732C; Wed, 17 Jun 2026 09:29:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781688549; cv=none; b=jTcxO7afjZRcrbJGHLeidxIru1VKfuUPk8KXeBmyX3ln/lk7PdTHzCS1pkzhKK5qLO7A/C59flOaJEaopSxIt9kDCYeRmsW8hBJNGdvB7A3pXLGE+u7FkqPsZJuX7NDhEI2aacoHtVvHqUcRGyrFlIe9lv8iVU28wq2u1JUVjQY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781688549; c=relaxed/simple; bh=bl4HHza+GTCgy+MYtBFrYAN0WFCZBYUrBco4XR9hSIM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=fG6xbPsquJpQdu1NgaIv1/71Ja/P8yVblMIyWIHOkn4iMgRaGGL7dIOuxCHtm96Etg3MZ4vtKWH7misLYxt/tpdTlsORugG4VqUf6kb+VdyNw525liM0vEaBO28fFuffFpKu5avpSwKND3UFB5TRrEFuMePclEKGVzDduS09g+I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Ka9YkXJH; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Ka9YkXJH" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5CB111F000E9; Wed, 17 Jun 2026 09:29:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1781688548; bh=bl4HHza+GTCgy+MYtBFrYAN0WFCZBYUrBco4XR9hSIM=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=Ka9YkXJHHhSQQnBqIKSEgvcoiOLqdDtfGSALn/LNvuy2b8RTgsJp39DWDURwtGQjI sxCeuYAXlA5pSal2qPm/tbUTvwxjWEMJbdbhe3Y76PO6dSTd2i31kqupihTqVaSl4i 0JyN4HwOwONPu1D2Wtvg7oltowBDz6evuehFMSRiDpA1ZDtSXI/LpoC0R5CPrLuoTC urb0kRVqbindWU5aebR7rtwOvjto39JuIenS7fz+LK4UphhkHAxvRYz1BmzheVpDnG IrKSXMSEAfhYxtwtNl3GiGSXwszvgmEBUJPuBpUQZRq7cEDjahfE1FQq/U2DyvZC2M OP5ICXShkpTWQ== Message-ID: <64c1908f-a46e-4489-8f1e-6dabd8afc8ae@kernel.org> Date: Wed, 17 Jun 2026 18:28:59 +0900 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 10/15] mm/slab: allow kmem_cache_alloc_bulk() with any gfp flags To: "Vlastimil Babka (SUSE)" Cc: Hao Li , Christoph Lameter , David Rientjes , Roman Gushchin , Suren Baghdasaryan , Alexei Starovoitov , Andrew Morton , Johannes Weiner , Michal Hocko , Shakeel Butt , Alexander Potapenko , Marco Elver , Dmitry Vyukov , kasan-dev@googlegroups.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org References: <20260615-slab_alloc_flags-v3-0-ce1146d140fb@kernel.org> <20260615-slab_alloc_flags-v3-10-ce1146d140fb@kernel.org> Content-Language: en-US From: Harry Yoo In-Reply-To: <20260615-slab_alloc_flags-v3-10-ce1146d140fb@kernel.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------iK2XvNSkWB0k77xTG0u4rrFL" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------iK2XvNSkWB0k77xTG0u4rrFL Content-Type: multipart/mixed; boundary="------------uHnflAN49MCDrkRrwOTzCyef"; protected-headers="v1" From: Harry Yoo To: "Vlastimil Babka (SUSE)" Cc: Hao Li , Christoph Lameter , David Rientjes , Roman Gushchin , Suren Baghdasaryan , Alexei Starovoitov , Andrew Morton , Johannes Weiner , Michal Hocko , Shakeel Butt , Alexander Potapenko , Marco Elver , Dmitry Vyukov , kasan-dev@googlegroups.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org Message-ID: <64c1908f-a46e-4489-8f1e-6dabd8afc8ae@kernel.org> Subject: Re: [PATCH v3 10/15] mm/slab: allow kmem_cache_alloc_bulk() with any gfp flags References: <20260615-slab_alloc_flags-v3-0-ce1146d140fb@kernel.org> <20260615-slab_alloc_flags-v3-10-ce1146d140fb@kernel.org> In-Reply-To: <20260615-slab_alloc_flags-v3-10-ce1146d140fb@kernel.org> --------------uHnflAN49MCDrkRrwOTzCyef Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 6/15/26 8:54 PM, Vlastimil Babka (SUSE) wrote: > The last user of gfpflags_allow_spinning() in slab is > alloc_from_pcs_bulk(), which is only called from > kmem_cache_alloc_bulk(). >=20 > It turns out that gfpflags_allow_spinning() is not necessary, because > kmem_cache_alloc_bulk() is only expected to be called from context that= > does allow spinning, so simply replace it with 'true'. This means we ca= n > also drop the gfp parameter from alloc_from_pcs_bulk(). >=20 > With that, we can remove the "@flags must allow spinning" part of the > kernel doc, as there is no more connection to the gfp flags in the slab= > implementation. >=20 > Also remove a comment in alloc_slab_obj_exts() because there should be > no more false positives possible due to gfp_allowed_mask during early > boot. >=20 > Link: https://patch.msgid.link/20260610-slab_alloc_flags-v2-11-7190909d= b118@kernel.org > Reviewed-by: Suren Baghdasaryan > Signed-off-by: Vlastimil Babka (SUSE) > --- Looks good to me, Reviewed-by: Harry Yoo (Oracle) --=20 Cheers, Harry / Hyeonggon --------------uHnflAN49MCDrkRrwOTzCyef-- --------------iK2XvNSkWB0k77xTG0u4rrFL Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQQQ1ub6gR5ogjaKRmOGXBN6rc5S1gUCajJo2wAKCRCGXBN6rc5S 1kq3AP9mF3O+9eEwZracOcmZ+bzXYCob2+uJSads3yNJGPzRFwEA7kRgdkoJgCoC 2inFLTTi3edE/X8QusVE5XIXADJypgA= =MW5p -----END PGP SIGNATURE----- --------------iK2XvNSkWB0k77xTG0u4rrFL--