From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751299AbdJWJSZ (ORCPT <rfc822;w@1wt.eu>);
        Mon, 23 Oct 2017 05:18:25 -0400
Received: from mout.web.de ([212.227.15.14]:55750 "EHLO mout.web.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1750811AbdJWJSX (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 23 Oct 2017 05:18:23 -0400
Subject: Re: um: Use common error handling code in port_listen_fd()
To: Dan Carpenter <dan.carpenter@oracle.com>,
        user-mode-linux-devel@lists.sourceforge.net
Cc: Jeff Dike <jdike@addtoit.com>, Richard Weinberger <richard@nod.at>,
        user-mode-linux-user@lists.sourceforge.net,
        kernel-janitors@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
References: <b16407cf-0caa-ea1d-7997-0e9a231468f3@users.sourceforge.net>
 <20171023084800.p26qcpb7iqyqrz4v@mwanda>
 <e248c905-eb76-d9bd-6e10-92be8b200590@users.sourceforge.net>
 <20171023091024.yxfva5p63zodj6bp@mwanda>
From: SF Markus Elfring <elfring@users.sourceforge.net>
Message-ID: <64ed8a02-3158-38b7-b795-efdc7f63e7e5@users.sourceforge.net>
Date: Mon, 23 Oct 2017 11:17:51 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.4.0
MIME-Version: 1.0
In-Reply-To: <20171023091024.yxfva5p63zodj6bp@mwanda>
Content-Type: text/plain; charset=utf-8
Content-Language: en-GB
Content-Transfer-Encoding: 7bit
X-Provags-ID: V03:K0:518EZZYevaB16Beb6Vl+pWyZKJ9s0HvDohDsPKVd5JcWBoP5vsK
 pU7XMWB1J/lejQPEKTIA4c8Hw06Q9sIm0xcFqoeOTwuAgWF9eSoZDvMed10DsmPA8iDXwu2
 wYD1sIDERGRBjo6cl0hJiHa2Sqi1AAR4NIcN4sRMSuzDB8/B6k+DK1yDi5TKs5cvndE/cE5
 P2FRb4Fmlgo8Jm0XXfa8w==
X-UI-Out-Filterresults: notjunk:1;V01:K0:rOu9CVlBroM=:Q9lbfeA8CUTpxJ3GSB3FnK
 58Lm4sfGVuPujglSMILDG5FnPGKp3YgzFYxt3GzdheAqy1Z6+SE4QmVwuGsftunAedDPIVf+R
 XFEZCkGG+3TVtJnfZk2yu4bgoilA2uGPAhBJE92lK/9b5Sa2i6r1urwqA3fDS3b7iAsvGiW12
 yT+yb4PKYtAzxsmNmw9UvDL5b1ZXRpPTcH8Krlc7sVkRpDTHI3dN+QtqTBRHdHZuGbb9i26me
 eqGD03ZuMWHa2dZ79efVkdUZ9frBXNZm6qA/RTPuaHnUfDxJBOSFM26tvILGhV4+pG5qpmFF9
 ZtEqBHh2mR9UzKrvmdi6c1lljlhGF1IgpPvDErhErtmcKzGWFsvEg3Mc7hQcA0L1WAxccvk+e
 GAYdR7hC3TzkRuYg55Z8C9D0yEWST6uH609R6xmfHco4Ug0vVkcH7kcstBQL/IFJGP2f69Oqf
 wXo+621/qFJRhbEp1GQrJu1ddWAkhQXE9EptDA7wpwdpmBLsobSU3i7LNw05zBb96F0geEP1z
 3heljzVgeXuUipGxDg7+Hgos1Ijt6qQ4iYz6+wPIOFgFkyt6oQMiEQbSTd0HV+qU4FpYIdz6w
 bgwUFUsKvW03C1mKm0BPp9uh5Bq8lLowjZBjo+Q9yhmol2uvwTerKnsG+YDsuIkGfRfHTSaQ8
 YS79BbWDIlGMhkd4nHvELIGRXGSOHBa8qO6ZlyA6U9oQEqK71mvaUkkfXRSsInitkEVAV16T3
 eRBgiDwz9EgJEt2cAKHO+kzorxJj6OqwpakVlX1OCPneeA0unzgacw1RQtcAfuR3bkepxVUhK
 j1YriLJx7r19TGe5NeVapU4niSJx35BXyajhx8GpCqVjWkvLIc=
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>> Could you become used to the proposed control flow structure
>> in the affected function?
>>
> 
> No.  Don't do this.

Thanks for your information.


> It's pointless obfuscation.

I disagree for this view.


>> There are some challenges around change acceptance as usual.
> 
> Yeah.  I knew it was pointless to ask you to stop this...  :(

The mixture of agreements and disagreements will evolve over time, won't they?

Regards,
Markus