From: Ghazale Hosseinabadi <ghazale.hosseinabadi@oracle.com>
To: <hal@dev.mellanox.co.il>
Cc: <linux-rdma@vger.kernel.org>, <tbogendoerfer@suse.de>,
<matanb@mellanox.com>, <leonro@mellanox.com>,
<parav@mellanox.com>, <linux-kernel@vger.kernel.org>,
<dledford@redhat.com>
Subject: Re: [PATCH] IB/mlx5: give back valid speed/width even without plugged in SFP module
Date: Fri, 27 Oct 2017 14:54:55 -0700 (PDT) [thread overview]
Message-ID: <64ef31c8-cb1a-4579-ba12-11fbf6d1d5c0@default> (raw)
Hi,
----- Original Message -----
From: hal@dev.mellanox.co.il
To: parav@mellanox.com, tbogendoerfer@suse.de, matanb@mellanox.com, leonro@mellanox.com, dledford@redhat.com, linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: ghazale.hosseinabadi@oracle.com
Sent: Friday, October 27, 2017 2:30:33 PM GMT -08:00 US/Canada Pacific
Subject: Re: [PATCH] IB/mlx5: give back valid speed/width even without plugged in SFP module
On 10/27/2017 4:33 PM, Parav Pandit wrote:
>
>
>> -----Original Message-----
>> From: Hal Rosenstock [mailto:hal@dev.mellanox.co.il]
>> Sent: Friday, October 27, 2017 3:19 PM
>> To: Parav Pandit <parav@mellanox.com>; Thomas Bogendoerfer
>> <tbogendoerfer@suse.de>; Matan Barak <matanb@mellanox.com>; Leon
>> Romanovsky <leonro@mellanox.com>; Doug Ledford <dledford@redhat.com>;
>> linux-rdma@vger.kernel.org; linux-kernel@vger.kernel.org
>> Cc: Ghazale Hosseinabadi <ghazale.hosseinabadi@oracle.com>
>> Subject: Re: [PATCH] IB/mlx5: give back valid speed/width even without plugged
>> in SFP module
>>
>> On 10/27/2017 2:32 PM, Parav Pandit wrote:
>>> However I believe that ibstat tool should be enhanced to report unknown port
>> speed instead of expecting drivers to supply some random number like this.
>>
>> ibstat gets the rate from libibumad via /sys/class/infiniband/<IB
>> device>/ports/<port number>/rate file which is supposed to be populated by the
>> driver. Is there no rate file in this error case ?
>>
> <...>/<port_num>/rate file exist.
>
> rate_show() has invalid active_width as expected due to nonexistence of SFP.
> So sysfs call return invalid value.
> We don't have invalid_active_width defined right now.
> So ibstat and other applications should not crash on such valid errors.
Agreed. I haven't seen ibstat crash reported though. Can someone provide
the crash details ?
When running ibstat (if transceiver is not connected in adapter):
ibpanic: [7851] main: stat of IB device 'mlx5_1' failed: Invalid argument
Thanks,
Ghazale
next reply other threads:[~2017-10-27 21:55 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-27 21:54 Ghazale Hosseinabadi [this message]
2017-10-27 22:52 ` [PATCH] IB/mlx5: give back valid speed/width even without plugged in SFP module Hal Rosenstock
2017-10-27 23:04 ` Ghazale Hosseinabadi
2017-10-27 23:19 ` Hal Rosenstock
2017-10-28 0:17 ` Hal Rosenstock
2017-10-28 0:29 ` Ghazale Hosseinabadi
2017-10-28 0:36 ` Ghazale Hosseinabadi
2017-10-28 10:42 ` Thomas Bogendoerfer
2017-10-28 11:59 ` Hal Rosenstock
-- strict thread matches above, loose matches on Subject: below --
2017-10-27 20:35 Ghazale Hosseinabadi
2017-10-27 12:30 Thomas Bogendoerfer
2017-10-27 18:32 ` Parav Pandit
2017-10-27 20:18 ` Hal Rosenstock
2017-10-27 20:33 ` Parav Pandit
2017-10-27 21:30 ` Hal Rosenstock
2017-10-27 19:35 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=64ef31c8-cb1a-4579-ba12-11fbf6d1d5c0@default \
--to=ghazale.hosseinabadi@oracle.com \
--cc=dledford@redhat.com \
--cc=hal@dev.mellanox.co.il \
--cc=leonro@mellanox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=matanb@mellanox.com \
--cc=parav@mellanox.com \
--cc=tbogendoerfer@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox