From: Jiri Slaby <jirislaby@kernel.org>
To: John de la Garza <john@jjdev.com>, gregkh@linuxfoundation.org
Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tty: tty_jobctrl: use guard() in tiocgsid()
Date: Thu, 2 Jul 2026 05:34:35 +0200 [thread overview]
Message-ID: <64f0a802-b057-4b26-9c1b-452591fb3fb4@kernel.org> (raw)
In-Reply-To: <20260701231215.4092457-1-john@jjdev.com>
On 02. 07. 26, 1:12, John de la Garza wrote:
> guard()s express more clearly what the lock protects and let the
> function return immediately instead of jumping to an unlock label.
Why did you send this twice? Other than that:
Reviewed-by: Jiri Slaby <jirislaby@kernel.org>
> Signed-off-by: John de la Garza <john@jjdev.com>
thanks,
--
js
suse labs
next prev parent reply other threads:[~2026-07-02 3:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-01 23:12 [PATCH] tty: tty_jobctrl: use guard() in tiocgsid() John de la Garza
2026-07-02 3:34 ` Jiri Slaby [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-07-01 21:49 John de la Garza
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=64f0a802-b057-4b26-9c1b-452591fb3fb4@kernel.org \
--to=jirislaby@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=john@jjdev.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox