From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oi1-f176.google.com (mail-oi1-f176.google.com [209.85.167.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A3CDB1F75B2 for ; Tue, 7 Jan 2025 23:46:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736293611; cv=none; b=QoxePPgeeaFo0r4Kveg8okc6S2d9b6OVjRCq4fWaA01u4y073iltZFjlTOgE0jbnPEdwKqoJGjokS2Mcku8uh8MVv0ol+jVxfB1KniwZRUbZ9GqgO4k1tjZrEss/A+lNW3A089sH5Iy+NapOLjFu2Aqz4t4eEbX2T6VoEVMsbco= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736293611; c=relaxed/simple; bh=JmeWNV5FcZLoOrrSKKyRkVhViGwgBqKbXGL/ScYkwNg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=pDH6bjV4C5c5GTreCk/tKQXdoeU6aHeOas0ovc8DY8jsp1A+zKzqk84eidLu1Nu8OqyvJ2lkHetyqicAZjJTQXapjLyvb2PxL6805nYA93iBZODSUZ4diSvsH3UHRF8pbv9Lig3LQCyYkWtnv8+wE4iT/ulwpQE1oYUSjLvD98E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=DsSTSjSi; arc=none smtp.client-ip=209.85.167.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="DsSTSjSi" Received: by mail-oi1-f176.google.com with SMTP id 5614622812f47-3eb880e5ac2so8222525b6e.2 for ; Tue, 07 Jan 2025 15:46:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1736293609; x=1736898409; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=SL3D1HRo7TiklJfqyB2qV4HRBGgMR/nUjUyi5xRuIbo=; b=DsSTSjSiVCgvdc4eouAesVPiG/aXJbfCdFwj+pAG8cxavc/8lvSRjcYH02+VIwYKIO XM+wsJwuFU8OcZwhhupKJoCMYxXlgWHec8zdWPAi/HNqMCucRMCUUlnqC5S1GTJt3tcU mtF1F/VDZBJUaw8pNPFHCaX52pE5Gg7njUwfzBxoigIY6SOcI4Ahz0WccaRi74h0q/Z3 yBOVN6gE5yZPY9cHHb61HUW/Cb1+0IMShNeGgAxQv2u+HB9Tym/RlEjJG58fW+YZWXBv qGlnf4XUQ5WZcf17m4PRQVZNMr/qIiU/xVyH/D6zRyPIGE32gHvejXGo4Phv5MdIAUwf yxYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736293609; x=1736898409; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=SL3D1HRo7TiklJfqyB2qV4HRBGgMR/nUjUyi5xRuIbo=; b=f+fMJ8CbQEUTavWlrfSr17rSWdLyzfJv96l/t/7a/JKnsv+W+hAhtgtwzeBfZUwG26 14OYHC9f7fN57WG4dhib4qbq9jaY2/feY672UC+7tk9+vDu8kkCA+I/IX9lbvEUynMO4 w/uDyN4e/2aVGhU8eszeR6EbejMDcbaM7jv2uv1KRhhyZQ81UrqnnSml9H2anV9u2o+n u1fwMfwmBlHcpN9Z5mfo6in8Qfu6/s8CAgOhofqkAeCnQuL17Ip9On5bA9lIeqxUX7AT +8fzHgW9RJUE4EX5eK57LqXbpQWOTu8kvHFxrsWbdMHw8s7f0/R4cpQXfGmDoGIdDv/r pYVg== X-Forwarded-Encrypted: i=1; AJvYcCUTU5zoTPPmlKHg2ZgBWeFio+KwjeIrWmcTVZBuirKhQbgtLDdbDOd11B4grFgnYxuPqK/BmTdp4uIzao0=@vger.kernel.org X-Gm-Message-State: AOJu0YzMgLREguzhJauFHWjjbi0wvXJdCtMcZZRVApztlnNsOkfFgRQd 8ame5h0ZsCbK9YVMGq0aL5uhy44X3HHleSPODTe6WVlzpZaWe/2cGh7ZvZjddQQ= X-Gm-Gg: ASbGncsCgg4JNV8XlxXBThOC8eF/ig6Ldn41uqXJN20B0sese8+jCQhTW8NgFVUJBBZ mUo9/fU/8jb3gBsL/2036UK2bR5iE7wCV0zFk7nuUSnghhfBwDg3A9CDF+GP/Xk7kTWiB+ddqkI Bpld5bXsg0mzbRKWQtfgyBqaYyGRGIbBkaeRA7NOLt3NlqSUMjaECd9t6KvRwEXMnCOJ4hL70jK pd7LU92wX6MzY36bo8dfui9bEFC4EdcELH82f42Z3tRYcG6PNAJSiRjHfgKD5TZ26tOgFNwlB0r rzn3TSUnrUT2yLJkaw== X-Google-Smtp-Source: AGHT+IHSaE+1p2b9DCmp1utb6983FC6IeOrjC2MthVra6tdatzMeuv9ulWTf8ZXQ867XR8BRedE1Rw== X-Received: by 2002:a05:6808:3c44:b0:3eb:5cdb:f477 with SMTP id 5614622812f47-3ef2ec26b4emr499945b6e.12.1736293608870; Tue, 07 Jan 2025 15:46:48 -0800 (PST) Received: from [192.168.0.142] (ip98-183-112-25.ok.ok.cox.net. [98.183.112.25]) by smtp.gmail.com with ESMTPSA id 5614622812f47-3ece25014dcsm10941403b6e.26.2025.01.07.15.46.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 07 Jan 2025 15:46:47 -0800 (PST) Message-ID: <64f913bf-a421-4def-a76c-6fcbc190fa64@baylibre.com> Date: Tue, 7 Jan 2025 17:46:45 -0600 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 11/15] iio: adc: ad7768-1: Add reg_write_masked function To: Jonathan Santos , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Sergiu Cuciurean , lars@metafoo.de, Michael.Hennerich@analog.com, jic23@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, marcelo.schmitt1@gmail.com References: <67649c43050d161621bc0494638bfa71fed82ea8.1736201898.git.Jonathan.Santos@analog.com> From: David Lechner Content-Language: en-US In-Reply-To: <67649c43050d161621bc0494638bfa71fed82ea8.1736201898.git.Jonathan.Santos@analog.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 1/7/25 9:26 AM, Jonathan Santos wrote: > From: Sergiu Cuciurean > > This commit adds the ad7768_spi_reg_write_masked() which is a helper > function for writing specific bits inside a register, without interfering > with the other bit values. > > Signed-off-by: Sergiu Cuciurean > --- > drivers/iio/adc/ad7768-1.c | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > > diff --git a/drivers/iio/adc/ad7768-1.c b/drivers/iio/adc/ad7768-1.c > index 574d735f2c3a..675af9ea856d 100644 > --- a/drivers/iio/adc/ad7768-1.c > +++ b/drivers/iio/adc/ad7768-1.c > @@ -242,6 +242,21 @@ static int ad7768_spi_reg_write(struct ad7768_state *st, > return spi_write(st->spi, st->data.d8, 2); > } > > +static int ad7768_spi_reg_write_masked(struct ad7768_state *st, > + unsigned int addr, > + unsigned int mask, > + unsigned int val) > +{ > + unsigned int reg_val; > + int ret; > + > + ret = ad7768_spi_reg_read(st, addr, ®_val, 1); > + if (ret < 0) > + return ret; > + > + return ad7768_spi_reg_write(st, addr, (reg_val & ~mask) | val); > +} > + > static int ad7768_set_mode(struct ad7768_state *st, > enum ad7768_conv_mode mode) > { Can we convert this driver to use regmap instead of reinventing it?