Re: [PATCH v3 1/1] PCI/ERR: Fix reset logic in pcie_do_recovery() call

Kuppuswamy, Sathyanarayanan
2020-09-28T18:32:28Z

On 9/28/20 11:25 AM, Sinan Kaya wrote:
> On 9/28/2020 2:02 PM, Sinan Kaya wrote:
>> Since there is no state restoration for FATAL errors, I am wondering
>> whether
>> calls to ->error_detected(), ->mmio_enabled() and ->slot_reset() are
>> required?
>
> I also would like to ask someone closer to the spec language double
> check this.
>
> When we recover the link at the end of the DPC handler, what is the
> expected state of the endpoint?
>
> Is it a some kind of a reset like secondary bus reset? (I assumed this
> one)
I think it will be in reset state.
>
> Undefined?
>
> or just plain link recovery with everything else as intact as it used
> to be?
>

--
Sathyanarayanan Kuppuswamy
Linux Kernel Developer