From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oa1-f49.google.com (mail-oa1-f49.google.com [209.85.160.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ECE5C1BEF75 for ; Sun, 12 Jan 2025 17:39:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736703600; cv=none; b=a5BIylZ8JfPV1yVTfuGaj/BsoJTbF7G06/p80B64QJ3fBPzK91a+BFokhBBwA3RHhdTFGarQE9qm24AXpqc+1V5bzxogSt5lBV0jLeS0fsw97H3cqOc7vfgmAJUw7zum73i9QomqowMHxn5EaJTVc9YSY5nARIeYNex72Z/TNKA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736703600; c=relaxed/simple; bh=Rrqq3QBfo3k3Aa5FLurl16fJUfPUp+yreDlshi7nQZQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Squy1oAf1BXk+bGSzRbgnPEMOyghxVtvYH7cEnZ7zz+OnDRB/54r0TRefcX6zdmEfIa75yNNlYlQrwWPQEiaJ7qEsOYXtsUpSMQmcHjASm9Qyml7IuKXHav0yrd5kNqV5QfxY8ipHwWTpep+VIuOkoX20dX6bH2F5Nr58l6jjMk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=UfQQTN1J; arc=none smtp.client-ip=209.85.160.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="UfQQTN1J" Received: by mail-oa1-f49.google.com with SMTP id 586e51a60fabf-29ff5c75c21so2414696fac.0 for ; Sun, 12 Jan 2025 09:39:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1736703597; x=1737308397; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=CUxaPIzm10Ty8QDpWslvn+ARqSUiRdFPc6JlyyrM+1M=; b=UfQQTN1JmMDfNYtFjlhJIGoR7OPg3D8eWOJidEUjLCBBTiCDjjJVqKn2I5EfgVeY6m 6w5VJIElqSbjPo0jbwJmNDGxMP7RSwW0+ZH8J+P4aBcqZQEysu7Htp1YfffL5KyK+x94 Ty/yf1KA3uDWoLjUWbRICl5od/43xfmmvyPzDqSEMTtMeay647LcWlq6IlItRPtqfYsJ Py00aJKxpMAOFjnvHUdj23OCOQzfkCq1hHAfeKCk1Z8oGAG+WvL+B69d1PDzIqQp6J8I jCHR+8HHDMFwmvPgfBV9BjoFEVgo4NSSRJPh4fol0X6Il2KVquvjdd0gbEthhwFlb7B3 ug0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736703597; x=1737308397; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=CUxaPIzm10Ty8QDpWslvn+ARqSUiRdFPc6JlyyrM+1M=; b=l6aiifZsRuNKroQ04VJPir7TGn0h9swKV5HsQjXoaxpHO7l44N/qauWFE4ohKyfkfs pYjC7prWalCqw7IC6DyAWu2ugX4t/48vJ8lI59Mq3BuqCvLDvUr/qW6X6yKqLqiM3yhw HB6Nam30Ozg3D8BlUR5U2TJoQ0QxjQLunTW/PluFx6NfDB/YCy5f5L839Pq4NEST5Trf /ter7yeCVAI0N+S15AOcxW3yhMA9FG8bMUwNjKGBvc0zk9Dm/j3CVSCAI+35Sltyc1hp QIwfTB9OmcU2q+XjF+qrTJEEba8MYqFRH7zh1XfUpgazKDgRZRwGGDP5PLYfio8iCVSq NxDg== X-Forwarded-Encrypted: i=1; AJvYcCVpUsGaNcTOmhg8ttofnY0Zv4jpSFNT4RC/HMZn6k5zWwTr+EAG3XJAkGmJwVmTETiuf4+qWzuYjp7aLRw=@vger.kernel.org X-Gm-Message-State: AOJu0YyErfF6NFrYo+FbKaqt7lIDbNrKTW6G5bNN1b51zBGwYG6J5r1V w1U1udgzJFP1uRJderVFiJjMg9zRsQndoCVrRWRJBIjX89bSkPOK6Z34K5veNz4= X-Gm-Gg: ASbGncu4a19iBxW22G/9zoc8hOM+otQ0ecYQJ4f0lAM8eoKNmGEnziJkiijxGTYcXwU Y7mquNB4DBrFDGSvwQP3sQ+9aqRxzAusndJJGhJj6UYEKF1IUmTmh5TEChRvJlXLO1tAF4/iLGy U+9cMuEobY9z+xBrDC3xo1nyTpHbrxviLz437K7q/ogOLkFuFZRy7sAaCnEh0is+IaBVhywSk0y 5UjxGQnpoPuPUzgzXpR03gMAmcMhXFaenHOHHfCvMvnUbKn17zNAwFT24pF480nAhe2bLhuUtoq jPjkTaQZnmeZO6/MiA== X-Google-Smtp-Source: AGHT+IFMeG8ihenSEkSFDLmmwiIOVBfVxAkRBcOo7FttPT2UR+B4w4RwRP+NuZvAmsZFcQCrdCZwYw== X-Received: by 2002:a05:6870:6e86:b0:297:281b:fb6d with SMTP id 586e51a60fabf-2ad8072db1dmr7361412fac.3.1736703597054; Sun, 12 Jan 2025 09:39:57 -0800 (PST) Received: from [192.168.0.142] (ip98-183-112-25.ok.ok.cox.net. [98.183.112.25]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-2ad804b0643sm2972251fac.3.2025.01.12.09.39.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 12 Jan 2025 09:39:56 -0800 (PST) Message-ID: <652a80dd-e951-4505-8e13-b5198c66c403@baylibre.com> Date: Sun, 12 Jan 2025 11:39:54 -0600 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 02/15] Documentation: ABI: add wideband filter type to sysfs-bus-iio To: 8601da92-1f08-40e3-9b39-f9b99dbc1507@baylibre.com Cc: Jonathan Santos , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, lars@metafoo.de, Michael.Hennerich@analog.com, jic23@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, marcelo.schmitt1@gmail.com References: <40707fa904ba7b1659554747ff7520139dd6f94e.1736201898.git.Jonathan.Santos@analog.com> <8601da92-1f08-40e3-9b39-f9b99dbc1507@baylibre.com> From: David Lechner Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 1/11/25 4:50 PM, Jonathan Santos wrote: > On 01/07, David Lechner wrote: >> On 1/7/25 9:24 AM, Jonathan Santos wrote: >>> The Wideband Low Ripple FIR filter is used for AD7768-1 Driver. >>> Document wideband filter option into filter_type_avaialable >> >> s/avaialable/available/ >> >>> attribute. >>> >>> Signed-off-by: Jonathan Santos >>> --- >>> Documentation/ABI/testing/sysfs-bus-iio | 2 ++ >>> 1 file changed, 2 insertions(+) >>> >>> diff --git a/Documentation/ABI/testing/sysfs-bus-iio b/Documentation/ABI/testing/sysfs-bus-iio >>> index f83bd6829285..c4c21a7bfba1 100644 >>> --- a/Documentation/ABI/testing/sysfs-bus-iio >>> +++ b/Documentation/ABI/testing/sysfs-bus-iio >>> @@ -2291,6 +2291,8 @@ Description: >>> * "sinc3+pf2" - Sinc3 + device specific Post Filter 2. >>> * "sinc3+pf3" - Sinc3 + device specific Post Filter 3. >>> * "sinc3+pf4" - Sinc3 + device specific Post Filter 4. >>> + * "wideband" - FIR filter with wideband low ripple passband >> >> I think "fir" would be a more specific filter type name than "wideband". (i.e. >> there are wikipedia pages for sinc and FIR filters, but not one for "wideband" >> filters) >> > > Isn't "fir" a bit too generic for this case? Since Wideband here is a class of a FIR filter. > Maybe something like "wideband-fir" or "fir-wideband" would work better? For this particular chip, no, there is only one FIR filter option on the chip, so having additional qualifiers doesn't really make a difference. If we can find a chip that has more than one FIR filter option, then we could use that to figure out what additional classifiers are might make sense. "fir-wideband" would only be useful if the same chip also had a "fir-narrowband" option. But we might find that instead the chip is actually "fir-type1" "fir-type2" or something like that. (FWIW, my signal processing textbook describes Type I, II, III, IV FIR filters but doesn't say anything about "wideband" FIR filters.) > >>> + and sharp transition band. >>> >>> What: /sys/.../events/in_proximity_thresh_either_runningperiod >>> KernelVersion: 6.6 >>