From: Timur Tabi <timur@codeaurora.org>
To: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Cc: Prarit Bhargava <prarit@redhat.com>,
linux-acpi@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org,
linux-serial@vger.kernel.org,
Bhupesh Sharma <bhsharma@redhat.com>,
Lv Zheng <lv.zheng@intel.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, Jonathan Corbet <corbet@lwn.net>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
graeme.gregory@linaro.org, mark.salter@redhat.com
Subject: Re: [PATCH v2 1/2] acpi, spcr: Make SPCR avialable to other architectures
Date: Thu, 14 Dec 2017 08:08:08 -0600 [thread overview]
Message-ID: <6541a055-bfd4-daa7-5b91-38384bd65c3f@codeaurora.org> (raw)
In-Reply-To: <20171214103027.GB697@e107981-ln.cambridge.arm.com>
On 12/14/17 4:30 AM, Lorenzo Pieralisi wrote:
>> I didn't want to put any ACPI code in amba-pl011.c, so putting it in spcr.c
>> made the most sense. I agree the global variable is ugly. If you have a
>> better idea, I'm all ears.
> I told you my idea. It could have been made easier by reusing the
> ACPI_DECLARE_PROBE_ENTRY() mechanism.
Sorry, I don't mean to be difficult, but when did you tell *me* this
idea of yours? I don't see any email from you to me that mentions
ACPI_DECLARE_PROBE_ENTRY(). I've never even heard of that macro before.
Please note that I'm not the original author of this code.
--
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm
Technologies, Inc. Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.
next prev parent reply other threads:[~2017-12-14 14:08 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-11 15:50 [PATCH v2 0/2] acpi, x86: Add SPCR table support Prarit Bhargava
2017-12-11 15:50 ` [PATCH v2 1/2] acpi, spcr: Make SPCR avialable to other architectures Prarit Bhargava
2017-12-13 0:22 ` Rafael J. Wysocki
2017-12-13 10:08 ` Will Deacon
2017-12-13 12:45 ` Lorenzo Pieralisi
2017-12-13 21:11 ` Timur Tabi
2017-12-14 10:30 ` Lorenzo Pieralisi
2017-12-14 14:08 ` Timur Tabi [this message]
2017-12-14 15:49 ` Lorenzo Pieralisi
2018-01-08 12:46 ` Prarit Bhargava
2017-12-11 15:50 ` [PATCH v2 2/2] acpi, x86: Use SPCR table for earlycon on x86 Prarit Bhargava
2017-12-12 10:41 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6541a055-bfd4-daa7-5b91-38384bd65c3f@codeaurora.org \
--to=timur@codeaurora.org \
--cc=bhsharma@redhat.com \
--cc=catalin.marinas@arm.com \
--cc=corbet@lwn.net \
--cc=graeme.gregory@linaro.org \
--cc=hpa@zytor.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=lv.zheng@intel.com \
--cc=mark.salter@redhat.com \
--cc=mingo@redhat.com \
--cc=prarit@redhat.com \
--cc=rjw@rjwysocki.net \
--cc=tglx@linutronix.de \
--cc=will.deacon@arm.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox