Re: [PATCH 2/2] [POWERPC] MPC8349E-mITX: use platform IDE driver for CF interface

Sergei Shtylyov
2007-07-25T18:27:49Z

Scott Wood wrote:

>> Also, what mmio-ide in the compat properly means in the context of
>>ide_platform which is able to handle both port and memory mapped IDE.
>>I think we must get rid with this crap, and since this IDE register
>>mapping is pretty much board specific, call it something like
>>"mpc8349emitx-ide" instead.

> What is board specific about a set of standard IDE registers at a given
> address? Do we need to make board-specific glue code for all of the
> various ns16550-compatibles out there as well?

I acn undertand your complaint in the context of an OF driver (which we
don't have yet) but "mmio-ide" just means nothing to the current driver, and
it doesn't convery enough info on the programming interface for the
conceivable OF driver, it also does need to know at least "reg-stride" (and
maybe "reg-size" in case only 16/32-bit accesses can be used). Well, if such
driver will be written, I/O mapping support will probably be dropped from it,
so indeed, calling it mmio-ide.c would make sense. But that can be added when
this driver is done, and for now I'd really prefer the board name to appear in
the "compatible" prop (to which "mmio-ide" can be appended)...

> -Scott

WBR, Sergei