Re: [PATCH 2/2] [POWERPC] MPC8349E-mITX: use platform IDE driver for CF interface

Scott Wood
2007-07-25T18:39:43Z

Sergei Shtylyov wrote:
> Hello.
>
> Scott Wood wrote:
>
>>> Also, what mmio-ide in the compat properly means in the context of
>>> ide_platform which is able to handle both port and memory mapped IDE.
>
>
>> I/O-space is only valid in the context of PCI, ISA, or similar buses, and
>> the bus-specific reg format indicates whether it's mmio-space or
>> io-space.
>
> You could save time on lecturing me (and use it to look on the driver
> ;-).

Sorry, I misread the question as being a mismatch between the
capabilities of the device binding and the driver, not about the
specific compatible name. Something like "generic-ide" would probably
be better.

>> What is board specific about a set of standard IDE registers at a given
>
> The regisrer mapping used is highly non-standard.

The gap between registers is nonstandard, but that's a fairly common
type of noncompliance in embedded-land, and probably merits being
supported in a generic way. I wouldn't call it "highly" nonstandard.

Is there some other non-standardness that I'm missing?

> We're already in board specific code, so why the heck not? :-)
>
>> various ns16550-compatibles out there as well?
>
> I never suggested that -- what I did suggest was make of_serial.c
> recognize certain chip types and register them with 8250 driver.

What would be the advantage of maintaining a list of chips whose only
difference is register spacing, rather than just using reg-shift and
being done with it?

-Scott