From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932753AbbIVITK (ORCPT ); Tue, 22 Sep 2015 04:19:10 -0400 Received: from mout.kundenserver.de ([212.227.17.13]:53924 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753746AbbIVITF (ORCPT ); Tue, 22 Sep 2015 04:19:05 -0400 From: Arnd Bergmann To: Ley Foon Tan Cc: Bjorn Helgaas , linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-pci@vger.kernel.org, lftan.linux@gmail.com Subject: Re: [PATCH 1/2] nios2: Add architectural support for PCIe Date: Tue, 22 Sep 2015 10:18:58 +0200 Message-ID: <65590637.5YmBIDOvTf@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <1442906367-10935-2-git-send-email-lftan@altera.com> References: <1442906367-10935-1-git-send-email-lftan@altera.com> <1442906367-10935-2-git-send-email-lftan@altera.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:6mC24lhj8JugC/Yh5LPExgUCKU1GjpBRYGMpFybkybOWJIzU/6T 27WIyH2Cm9BPBvLcDO8Th0G3/bnt3UNIhFfR88V9jO73QhKOPnwuAwmuF8NC98Z8cXtHc1I i/HSXBM0wkn+DOEmvcZpemLMu0D8++EbTTKVViLtA2SZN2pE9chTmHPy8dtuYParnjjdhcy gjBv1iQ7p6YUsHw255b1g== X-UI-Out-Filterresults: notjunk:1;V01:K0:lrX8WQT8mgU=:DGY5mymoiOBMrFEzB/XtoX T9O25ZQVqFTIEJG3x/meOSkb+7CD9wlIKn7R/DkTEbljcK7cTuEWvfNgzp2W9iacp+b8Cts8t GNP1KGNMzYO1fiIOHnPKmFKR1arZLGZj31T2zlaXtD9/IVn724ZhwlTgaybqs1e2kdJmfcX36 2IKWMFlO7ae9aPq+kwl6mQndbhmpoiHUFnW5ZnvYJYtgeEplN6FtvUbfVivFoRRLz6yr9jLob /LargooyCzAREmEYX0rxJ8qR1obNOzWAWBFLqbLwpjVs4/irVoaW60qLnz2IDO/MZjn+p1UW4 f+AcV0aC/Pf9Rg5fu0WkCRvHKSBG9Xu84yRwOnYyWIlJaH/OAgqSA0iPbJcc7c7cyyOMnG40K pSmNtuzUyeKUPY3ri0rBo4shS+/hS9Csyud2vuOXtiovwa9SImB/FGDwRcNPQ5650D0qTJcf3 6o2w2S3MzaSBTJAO6Jz+4Oywa9b0Jm2WcbjRn7DCrhtGWPz/REmuVkJfNBu/fRzy1B73YslZL ZGgvwG2UZ6Do+ISKW56iDkcHz2fA4i/LpOOQpzUJSIBM4iWOo3aVBS3Ks6hz2W8jYWjT+72zq F4d0UwsMfi/ob3jM2X732bS9xpPTHMmAus3AcZOO4CqdTTkxir+js8/DDDZcj2y8fRmTggXGL 5cKTAAvH/0ka9xmq4vOCelanF0BoJzTU6YYRHYkt1Uqd7ICpd3O6Go1NbsoYPSZ0lLCOu7FwF VAbGZSbgxhHiLrFu Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday 22 September 2015 15:19:26 Ley Foon Tan wrote: > + > +config PCI_SYSCALL > + def_bool PCI IIRC, PCI_SYSCALL is deprecated and you should just leave that turned off. In any case, you enable the syscalls here but don't assign a system call number, so that is rather pointless. I I might be missing something though. Bjorn? > @@ -14,7 +14,7 @@ > #include > #include > > -/* PCI is not supported in nios2, set this to 0. */ > +/* PCI I/O space is not supported, set this to 0. */ > #define IO_SPACE_LIMIT 0 > > #define readb_relaxed(addr) readb(addr) It might be useful to enable this, just in case someone connects a PCI host bridge that does support I/O space. Which host bridge do you use? Are you sure there is no I/O space? Most of them use a set of translation windows to set up a mapping between bus address (memory, config and io space) and physical (mmio) space. > diff --git a/arch/nios2/include/asm/pci.h b/arch/nios2/include/asm/pci.h > new file mode 100644 > index 0000000..f2cba05 > --- /dev/null > +++ b/arch/nios2/include/asm/pci.h What happens if you use the asm-generic header? If there is something missing in it, we can try to get it to do the right things. Arnd