From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8E3D9242D91 for ; Thu, 18 Dec 2025 07:12:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766041923; cv=none; b=eTaAJ6zpjHTwdQj29euxsecJqEZCEy0ho10Ecq+Vs0q9RvRbL2MlJL5oHidFAgCrMVs1W4nT4rBlkedoooQNucEOSl8at+MAYRltfMhWHHeJVXqQT2B8UpGknDcbo2JHuEd3dA5QqjWjUU8Ht14kVxQX9qHkR+BUgf0FaWv/lLU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766041923; c=relaxed/simple; bh=eaV6vluudAHtjLWNiyDXoFoLoPIaqPnfRwyUT1oVBzM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=SN+Nq16CtMr/artukyPwEarV0SQdmteItXvkSU1UcPs6K2YSeeqU4bdYXLmKT22Ye+ti4rnZDKHImmKbp5trb+NJubW7/HkXce+IhZwmfM6Wb2lybKL1UZcHu6WSUWMikESd+NyAQNyORHBmODb3ImOZtLmmZP3/nknTziEdrD4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=palhzTLb; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="palhzTLb" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A5FF7C4CEFB; Thu, 18 Dec 2025 07:11:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1766041923; bh=eaV6vluudAHtjLWNiyDXoFoLoPIaqPnfRwyUT1oVBzM=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=palhzTLbgkFchjBj9NEm1y2UtB0vAj0Hdms0FFq3DYfMHhUwPvJpGc49F3seDo5jI HGEerhaXjRKQXirYAfDJZB1jX3ePhSrvz6du2TXwQ1Ex49uJlLxDA3aEga9EywZQJh nqk9lfrAqq5Qs4ysO+fJo8SeQYcRKogEPym/5daOvz9djuY+sFP0a/eO+ZteA0f3F9 onsr+AVGePwjszqbf4KBqff+FPTFH+g6gFWUmmXRbkqjDUJKFcfWHt+bLiQ8z5cuWt /iCg+cVTScTsTPOTLvYh3fySS4ukio5UHuU+yyPPEaXG9G4jcjKUdiNeC09xRMw34I eP2sdxGzRVI4Q== Message-ID: <6559e53d-e940-4989-8bd2-de9a6cf9f62e@kernel.org> Date: Thu, 18 Dec 2025 08:11:57 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v10 1/8] treewide: provide a generic clear_user_page() variant To: Ankur Arora , linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org Cc: akpm@linux-foundation.org, bp@alien8.de, dave.hansen@linux.intel.com, hpa@zytor.com, mingo@redhat.com, mjguzik@gmail.com, luto@kernel.org, peterz@infradead.org, tglx@linutronix.de, willy@infradead.org, raghavendra.kt@amd.com, chleroy@kernel.org, ioworker0@gmail.com, boris.ostrovsky@oracle.com, konrad.wilk@oracle.com References: <20251215204922.475324-1-ankur.a.arora@oracle.com> <20251215204922.475324-2-ankur.a.arora@oracle.com> From: "David Hildenbrand (Red Hat)" Content-Language: en-US In-Reply-To: <20251215204922.475324-2-ankur.a.arora@oracle.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 12/15/25 21:49, Ankur Arora wrote: > From: David Hildenbrand > > Let's drop all variants that effectively map to clear_page() and > provide it in a generic variant instead. > > We'll use the macro clear_user_page to indicate whether an architecture > provides it's own variant. Maybe at some point these should be CONFIG_ > options. Can we drop the second sentence? > > Also, clear_user_page() is only called from the generic variant of > clear_user_highpage(), so define it only if the architecture does > not provide a clear_user_highpage(). And, for simplicity define it > in linux/highmem.h. > > Note that for parisc, clear_page() and clear_user_page() map to > clear_page_asm(), so we can just get rid of the custom clear_user_page() > implementation. There is a clear_user_page_asm() function on parisc, > that seems to be unused. Not sure what's up with that. > > Signed-off-by: David Hildenbrand You should likely now add Co-developed-by: Ankur Arora above your SB :) > Signed-off-by: Ankur Arora Skimmed over it and nothing jumped at me. -- Cheers David