Re: [usb-storage] BUG: SCSI: usb storage SDHC card doesn't work in 2.6.27-rc1

Alan Stern
2008-08-08T21:30:23Z

On Fri, 8 Aug 2008, Matthew Frost wrote:

> > > > Index: 2.6.26/drivers/usb/storage/transport.c
> > > > ===================================================================
> > > > --- 2.6.26.orig/drivers/usb/storage/transport.c
> > > > +++ 2.6.26/drivers/usb/storage/transport.c
> > > > @@ -1034,8 +1034,21 @@ int usb_stor_Bulk_transport(struct scsi_
> > > >
> > > > /* try to compute the actual residue, based on how much data
> > > > * was really transferred and what the device tells us */
> > > > - if (residue) {
> > > > - if (!(us->flags & US_FL_IGNORE_RESIDUE)) {
> > > > + if (residue && !(us->flags & US_FL_IGNORE_RESIDUE)) {
> > > > +
> > > > + /* Heuristically detect devices that generate bogus residues
> > > > + * by seeing what happens with INQUIRY and READ CAPACITY
> > > > + * commands.
> > > > + */
> > > > + if (bcs->Status == US_BULK_STAT_OK &&
> > > > + scsi_get_resid(srb) == 0 &&
> > > > + ((srb->cmnd[0] == INQUIRY &&
> > > > + transfer_length == 36) ||
> > > > + (srb->cmnd[0] == READ_CAPACITY &&
> > > > + transfer_length == 8))) {
> > > > + us->flags |= US_FL_IGNORE_RESIDUE;
> > > > +
> > > > + } else {
> > > > residue = min(residue, transfer_length);
> > > > scsi_set_resid(srb, max(scsi_get_resid(srb),
> > > > (int) residue));
> > > >
> > > >
> > >
> > > Thanks! I've been trying to fix it manually, and it wouldn't work.
> > Trying
> > > this version now. Let's see if this fixes my problem.
> > >
> > > Matt Frost
> > >
> >
> > Tested under two distributions, this patch restores correct functionality
> > to my hardware. Thank you very much!
> >
> > Matt
> >
> Update/sqeaking-of-the-wheel:
>
> The same problem still happens under 2.6.27-rc2, and I haven't seen this
> bumped to -stable, either. It continues to solve the problem here.

The patch has not yet been pushed to mainline but it is present in Greg
KH's USB development tree. Presumably it will end up in the mainline
kernel before 2.6.27-final is released.

Alan Stern