From: Christian Marangi <ansuelsmth@gmail.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Florian Fainelli <florian.fainelli@broadcom.com>,
Broadcom internal kernel review list
<bcm-kernel-feedback-list@broadcom.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Vladimir Oltean <olteanv@gmail.com>,
David Epping <david.epping@missinglinkelectronics.com>,
"Russell King (Oracle)" <rmk+kernel@armlinux.org.uk>,
Harini Katakam <harini.katakam@amd.com>,
Simon Horman <horms@kernel.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [net-next PATCH v2 3/4] net: phy: restructure __phy_write/read_mmd to helper and phydev user
Date: Tue, 28 Nov 2023 13:11:00 +0100 [thread overview]
Message-ID: <6565d8d6.5d0a0220.5f8f1.b9d7@mx.google.com> (raw)
In-Reply-To: <d3747eda-7109-4d53-82fa-9df3f8d71f62@lunn.ch>
On Tue, Nov 28, 2023 at 01:46:10AM +0100, Andrew Lunn wrote:
> On Mon, Nov 27, 2023 at 12:51:40AM +0100, Christian Marangi wrote:
> > Restructure phy_write_mmd and phy_read_mmd to implement generic helper
> > for direct mdiobus access for mmd and use these helper for phydev user.
> >
> > This is needed in preparation of PHY package API that requires generic
> > access to the mdiobus and are deatched from phydev struct but instead
> > access them based on PHY package base_addr and offsets.
>
> Why is this all going into the header file?
>
Was following the pattern done by phy_package_read/write.
Considering those API are not single function call... I wonder if those
should be moved in phy_core.c instead of static inline them in the
header.
What do you think?
--
Ansuel
next prev parent reply other threads:[~2023-11-28 12:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-26 23:51 [net-next PATCH v2 1/4] net: phy: extend PHY package API to support multiple global address Christian Marangi
2023-11-26 23:51 ` [net-next PATCH v2 2/4] net: phy: move mmd_phy_indirect to generic header Christian Marangi
2023-11-26 23:51 ` [net-next PATCH v2 3/4] net: phy: restructure __phy_write/read_mmd to helper and phydev user Christian Marangi
2023-11-28 0:46 ` Andrew Lunn
2023-11-28 12:11 ` Christian Marangi [this message]
2023-11-28 12:22 ` Russell King (Oracle)
2023-11-26 23:51 ` [net-next PATCH v2 4/4] net: phy: add support for PHY package MMD read/write Christian Marangi
2023-11-28 0:51 ` Andrew Lunn
2023-11-28 12:12 ` Christian Marangi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6565d8d6.5d0a0220.5f8f1.b9d7@mx.google.com \
--to=ansuelsmth@gmail.com \
--cc=andrew@lunn.ch \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=davem@davemloft.net \
--cc=david.epping@missinglinkelectronics.com \
--cc=edumazet@google.com \
--cc=florian.fainelli@broadcom.com \
--cc=harini.katakam@amd.com \
--cc=hkallweit1@gmail.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=rmk+kernel@armlinux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox