From: Evgeniy Polyakov <zbr@ioremap.net>
To: Hans-Frieder Vogt <hfvogt@gmx.net>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 0/2] w1 fixes for broken subsystem
Date: Mon, 07 Oct 2013 00:45:44 +0400 [thread overview]
Message-ID: <65711381092344@web10h.yandex.ru> (raw)
In-Reply-To: <9348473.dVMUCnY2zF@maximilian>
Hi
06.10.2013, 23:13, "Hans-Frieder Vogt" <hfvogt@gmx.net>:
> In recent kernels the 1-wire kernel modules do not work any more. The module
> wire got broken in 3.11-rc1 and 3.12-rc1 introduced a further problem:
Looks like I somehow missed it and bugs got in
> 1: 3.11-rc1 introduced the automatic loading of slave modules. This blocks
> modprobe, because request_module is called with a locked mutex of the w1
> master.
> Loading of the slave module calls w1_register_family, which calls in turn
> w1_reconnect_slaves and there mutex_lock(&dev->mutex) will wait forever....
That's correct
> 2: 3.12-rc1 introduced w1_bus_notify which assumes that all slaves have fops
> defined. This is not the case for e.g. w1_smem and maybe also breaks custom
> written modules.
Isn't fops are supposed to be in the slave device?
Although they look meaningless for most of devices, I would introduce them everywhere...
But anyway, your patches fix those problems, thanks a lot.
Greg, please queue them into appropriate trees.
Acked-by: Evgeniy Polyakov <zbr@ioremap.net>
next prev parent reply other threads:[~2013-10-06 20:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-06 19:13 [PATCH 0/2] w1 fixes for broken subsystem Hans-Frieder Vogt
2013-10-06 20:45 ` Evgeniy Polyakov [this message]
2013-10-06 20:56 ` gregkh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=65711381092344@web10h.yandex.ru \
--to=zbr@ioremap.net \
--cc=gregkh@linuxfoundation.org \
--cc=hfvogt@gmx.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox