From: Arnd Bergmann <arnd@arndb.de>
To: Baoyou Xie <baoyou.xie@linaro.org>
Cc: alexander.deucher@amd.com, airlied@linux.ie, Rex.Zhu@amd.com,
Jammy.Zhou@amd.com, JinHuiEric.Huang@amd.com,
tom.stdenis@amd.com, funfunctor@folklore1984.net,
vitaly.prosyak@amd.com, eric.yang2@amd.com, Young.Yang@amd.com,
ray.huang@amd.com, dan.carpenter@oracle.com, Flora.Cui@amd.com,
nils.wallmenius@gmail.com, Monk.Liu@amd.com,
Qingqing.Wang@amd.com, Frank.Min@amd.com,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
xie.baoyou@zte.com.cn, han.fei@zte.com.cn,
tang.qiang007@zte.com.cn
Subject: Re: [PATCH] drm/amd/powerplay: mark symbols static where possible
Date: Mon, 24 Oct 2016 22:51:07 +0200 [thread overview]
Message-ID: <6582910.6C6abby7Jc@wuerfel> (raw)
In-Reply-To: <1477126582-2906-1-git-send-email-baoyou.xie@linaro.org>
On Saturday, October 22, 2016 4:56:22 PM CEST Baoyou Xie wrote:
> @@ -1341,7 +1341,7 @@ int smu7_disable_dpm_tasks(struct pp_hwmgr *hwmgr)
> return result;
> }
>
> -int smu7_reset_asic_tasks(struct pp_hwmgr *hwmgr)
> +static int smu7_reset_asic_tasks(struct pp_hwmgr *hwmgr)
> {
>
> return 0;
>
This needs to be done differently:
../drivers/gpu/drm/amd/amdgpu/../powerplay/hwmgr/smu7_hwmgr.c:1344:12: error: 'smu7_reset_asic_tasks' defined but not used [-Werror=unused-function]
The function has no callers, so the easiest way would be to remove it
entirely, but it's possible that there are plans to add users soon.
Arnd
next prev parent reply other threads:[~2016-10-24 20:51 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-22 8:56 [PATCH] drm/amd/powerplay: mark symbols static where possible Baoyou Xie
2016-10-22 9:28 ` Edward O'Callaghan
2016-10-24 16:36 ` Alex Deucher
2016-10-24 19:49 ` Arnd Bergmann
2016-10-24 20:07 ` Deucher, Alexander
2016-10-24 20:41 ` Arnd Bergmann
2016-10-25 6:41 ` Daniel Vetter
2016-10-25 7:09 ` Christian König
2016-10-25 8:11 ` Daniel Vetter
2016-10-24 20:51 ` Arnd Bergmann [this message]
[not found] ` <CA+DQWkxdO72H4ZbUkYyJwPOe2JGRv_Tz1eUkZ5=FJoOonoWp=Q@mail.gmail.com>
2016-10-25 8:15 ` Arnd Bergmann
2016-10-25 20:07 ` Deucher, Alexander
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6582910.6C6abby7Jc@wuerfel \
--to=arnd@arndb.de \
--cc=Flora.Cui@amd.com \
--cc=Frank.Min@amd.com \
--cc=Jammy.Zhou@amd.com \
--cc=JinHuiEric.Huang@amd.com \
--cc=Monk.Liu@amd.com \
--cc=Qingqing.Wang@amd.com \
--cc=Rex.Zhu@amd.com \
--cc=Young.Yang@amd.com \
--cc=airlied@linux.ie \
--cc=alexander.deucher@amd.com \
--cc=baoyou.xie@linaro.org \
--cc=dan.carpenter@oracle.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=eric.yang2@amd.com \
--cc=funfunctor@folklore1984.net \
--cc=han.fei@zte.com.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=nils.wallmenius@gmail.com \
--cc=ray.huang@amd.com \
--cc=tang.qiang007@zte.com.cn \
--cc=tom.stdenis@amd.com \
--cc=vitaly.prosyak@amd.com \
--cc=xie.baoyou@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox