From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f43.google.com (mail-pj1-f43.google.com [209.85.216.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7124F423A6D for ; Tue, 28 Apr 2026 12:22:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777378935; cv=none; b=uveOd4yBl7MemR/88i/Dd642eMRjJ+pvtVa69kxH3a75C+hTiB3DlPe49vX8DeykNDlGblrD3GNFKucD0nHcd88/sKfjlrZqWRXunmOL8QIkTtePHO6gHk4Hb6XqA/ikOeG8ISzU7+ENtPB0gxLdugO83Y9LT4Wrqo3XVwHQ6RQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777378935; c=relaxed/simple; bh=eYPmyiMGSedPs8Nz6KaAqMfRG2j7jcSEfi7C64leoOo=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=a49Hm21KVWEMhLxw/gvOo8f34ifab2AnhqD31gXJT0GkdHcoVXvyqdUn5hWp2/RuqplP8E2opI8HKfxmpB/5LFRaPx/xRY9QFUhPySHIOKMnMmANxWYNjGRyUlVLPdzp/Wyc9HBa97Vu3EphAbtG0DRDT9qgyH0QwcLBOVsDrK4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=X+5HNLPn; arc=none smtp.client-ip=209.85.216.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="X+5HNLPn" Received: by mail-pj1-f43.google.com with SMTP id 98e67ed59e1d1-35da1af3e10so10462355a91.3 for ; Tue, 28 Apr 2026 05:22:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777378927; x=1777983727; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:subject:from:user-agent:mime-version:date:message-id:from:to :cc:subject:date:message-id:reply-to; bh=eYPmyiMGSedPs8Nz6KaAqMfRG2j7jcSEfi7C64leoOo=; b=X+5HNLPnvrHMrNvEklBf9QLL7d/h/vmSwyQchRWz8qWl/nJ/tAaaLOHeglkvjl/7b6 ZYEpkn2ZAe+o0gw+Tz6mDS5L7RLlrxv6lGHRoPPCupkS0pJk1fCZPqq2pmgkBVb4AOf+ akDfXc8+2Bm1FBmqbUgK1Wauvy6fNQpNi9PWOZaotEkeWzEsPKMb6EWxKKQn7l4jsosc jC6Guo16iuAGd2CaSkv4sILLid+k1rjs9dWMkfWua4DL+vJ0uI/R6/piItUQeuAnNU+e NffETEUEnwV1IOQkClJQZkBiuajbfOkw6YaEHOZfcVuknkdSP9ppaeE0V0fynYNsySEE V7YA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777378927; x=1777983727; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:subject:from:user-agent:mime-version:date:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=eYPmyiMGSedPs8Nz6KaAqMfRG2j7jcSEfi7C64leoOo=; b=UltTc3ewO6weNvNGrtddE7jX+XUnoxNCMnvszo0XW2qC5QopUftQCPz2QJCSDWtZpa ApQ5fZxAFdkcBKH5Mr7B8AJvnmTr3Pn+ZLIFRK33bSTsDcS/uLN43z4PKEp153Mv80uj 0RsEMDCRk/PlgjJvhLKt2VItCydG9oPYSs4D3ku+NCg0t7X19AUAXs0bsUaqdtOoCEQE OR/WLEVBOjnxXpB2wts/svuBXakYVAbFo84aa/NQEAd9wWapgmNg7mZinYKOj25++Fko 1SUSSMu6qsUTo5XBth1vjWassAqYBOPcVX1QwKXfC6TVZnhsvcTFu9pn0RaaWlbBLs4W tBew== X-Forwarded-Encrypted: i=1; AFNElJ/lT842j39v/tTRCwKVBKZAfJmp42JnzgPPlG/6ApzdWCKPUOp+/sBm5m7khL8Bvk8EfBNdD7o3ETyC1Aw=@vger.kernel.org X-Gm-Message-State: AOJu0Yx8ooYMcbWeJ6h4cOBbk55Ixs4LGwtf1mbWE7QSUiwMKFhCaQuc Xj7qgKcX20zKXguGWj1x1N7jO36V7L86KAD3mXlCgRKPcj26clUZJR6E X-Gm-Gg: AeBDieuC1iUTJOyySsT2gJvsNFJT1H5RdUTMRAw3gE1GcTkopxbvEjWzOZHhuH56YxD 4tlc/w99qccDxRCKjp0QeyoXejsb5TJid6k0/MUb3N0VI7UEgLcBANlsgOUYorlsIiluzgdKHZS 27V9wmp4A6+jiWDSVjib0HEmRFAXSgwp1C8F/hJ2E/uwd4+PDcXLnfQHuhdB+/gTcBE6t0u2GQj yjhjKPO4CQik+a8wY+LvzU6xSplit41D3xDzANWxH5o5EvOcZmJjN0VOBE9s/GTX8QSscwcxEUV Sn2KH+ZjQU1puOJBZL2Tb+iQgt95VgFXd9vo2axscTyi+hSH5tr8KB3JOmNq4ab9J3ovEq4y9Ip 40d3l7uZvmruKjFbeoHMSvhflEQ9KMBa7b7U1cgdwRPJbx6ajv6qm3vYhE/mGmaCYkzZ1WXqRcX tFzrNc0ElMtEFbzWfOthZ6sB1fJYbDgvSBOGjDgYlBkMofMe0kMp5/gGvLoa4Id0ptMCq4uA169 2qx4TEKz4c= X-Received: by 2002:a17:90b:2f8f:b0:35c:30a8:330 with SMTP id 98e67ed59e1d1-36491c8837amr2989046a91.0.1777378927430; Tue, 28 Apr 2026 05:22:07 -0700 (PDT) Received: from ?IPV6:2001:da8:201d:1103:3367:a44:8d5a:228a? ([2001:da8:201d:1103:3367:a44:8d5a:228a]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-36490de9f9asm2987905a91.8.2026.04.28.05.22.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 28 Apr 2026 05:22:07 -0700 (PDT) Message-ID: <65911f89-e1ef-4da1-aa41-d261e5162f71@gmail.com> Date: Tue, 28 Apr 2026 20:21:58 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Linpu Yu Subject: Re: [PATCH v2 bpf 1/1] xskmap: reject TX-only AF_XDP sockets To: kerneljasonxing@gmail.com, magnus.karlsson@intel.com, maciej.fijalkowski@intel.com, netdev@vger.kernel.org, bpf@vger.kernel.org Cc: sdf@fomichev.me, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, horms@kernel.org, ast@kernel.org, daniel@iogearbox.net, hawk@kernel.org, john.fastabend@gmail.com, bjorn@kernel.org, linux-kernel@vger.kernel.org, tanyuan98@outlook.com, yifanwucs@gmail.com References: <2b156bc4277a9e891f3399935416701d1f9efd7c.1777276241.git.linpu5433@gmail.com> Content-Language: en-US In-Reply-To: <2b156bc4277a9e891f3399935416701d1f9efd7c.1777276241.git.linpu5433@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Thanks for catching this. fbfc504a24f5 is not the correct Fixes target. At that point, AF_XDP did not yet have TX ring support in the UAPI, and xsk_bind() also required xs->rx to exist, so a TX-only socket was not constructible there. Tx queue support came later in f61459030ec7 ("xsk: add Tx queue setup and mmap support"), but XSKMAP updates still rejected sockets without an Rx ring via xsk_is_setup_for_bpf_map(). The regression was introduced when 968be23ceaca removed that check. I have corrected the Fixes tag accordingly in v3.