From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE071C33CB1 for ; Tue, 14 Jan 2020 09:54:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C5B8624673 for ; Tue, 14 Jan 2020 09:54:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729212AbgANJyE (ORCPT ); Tue, 14 Jan 2020 04:54:04 -0500 Received: from mga11.intel.com ([192.55.52.93]:45604 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725842AbgANJyD (ORCPT ); Tue, 14 Jan 2020 04:54:03 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Jan 2020 01:54:02 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,432,1571727600"; d="scan'208";a="372535800" Received: from linux.intel.com ([10.54.29.200]) by orsmga004.jf.intel.com with ESMTP; 14 Jan 2020 01:54:02 -0800 Received: from [10.226.39.11] (unknown [10.226.39.11]) by linux.intel.com (Postfix) with ESMTP id 90F395802B1; Tue, 14 Jan 2020 01:54:01 -0800 (PST) Subject: Re: [PATCH] dt-bindings: reset: intel,rcu-gw: Fix intel,global-reset schema To: Rob Herring , devicetree@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Philipp Zabel References: <20200113214515.3950-1-robh@kernel.org> From: Dilip Kota Message-ID: <6594eba7-fb23-b741-4490-da27573fe132@linux.intel.com> Date: Tue, 14 Jan 2020 17:54:00 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.9.1 MIME-Version: 1.0 In-Reply-To: <20200113214515.3950-1-robh@kernel.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 1/14/2020 5:45 AM, Rob Herring wrote: > The intel,rcu-gw binding example has an error: > > Documentation/devicetree/bindings/reset/intel,rcu-gw.example.dt.yaml: > reset-controller@e0000000: intel,global-reset: [[16, 30]] is too short > > The error isn't really correct as the problem is in how the data is > encoded and the schema is not fixed up by the tooling correctly. > However, array properties should describe the elements in the array, so > lets do that which fixes the error in the process. Sure, i will add the change describing the array properties and push as a fix patch. Regards, Dilip > > Fixes: b7ab0cb00d08 ("dt-bindings: reset: Add YAML schemas for the Intel Reset controller") > Cc: Philipp Zabel > Cc: Dilip Kota > Signed-off-by: Rob Herring > --- > Documentation/devicetree/bindings/reset/intel,rcu-gw.yaml | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/reset/intel,rcu-gw.yaml b/Documentation/devicetree/bindings/reset/intel,rcu-gw.yaml > index 246dea8a2ec9..8ac437282659 100644 > --- a/Documentation/devicetree/bindings/reset/intel,rcu-gw.yaml > +++ b/Documentation/devicetree/bindings/reset/intel,rcu-gw.yaml > @@ -23,7 +23,11 @@ properties: > description: Global reset register offset and bit offset. > allOf: > - $ref: /schemas/types.yaml#/definitions/uint32-array > - - maxItems: 2 > + items: > + - description: Register offset > + - description: Register bit offset > + minimum: 0 > + maximum: 31 > > "#reset-cells": > minimum: 2