From: Paul Menage <menage@google.com>
To: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: Li Zefan <lizf@cn.fujitsu.com>,
Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>,
Linux Containers <containers@lists.linux-foundation.org>,
Balbir Singh <balbir@linux.vnet.ibm.com>
Subject: Re: [PATCH] cgroups: handle failure of cgroup_populate_dir() at mount/remount
Date: Tue, 26 May 2009 15:06:25 -0700 [thread overview]
Message-ID: <6599ad830905261506x480f2167naf1034177bbc7036@mail.gmail.com> (raw)
In-Reply-To: <20090522172545.1e5e5f81.kamezawa.hiroyu@jp.fujitsu.com>
On Fri, May 22, 2009 at 1:25 AM, KAMEZAWA Hiroyuki
<kamezawa.hiroyu@jp.fujitsu.com> wrote:
>
> Hm, shouldn't we allow "noprefix" to be effective only agaisnt cpuset ?
> I think it's just for backward-compatibility of cpuset.
> (I don't like the option at all.)
Yes, exposing the "noprefix" option externally was one of the mistakes
I made when developing cgroups.
It seems to me really unlikely that anyone is using "noprefix" for
anything other than implicitly when mounting the "cpuset" filesystem.
So I'd be inclined to just forbid it if we're mounting more than just
the cpuset subsystem. A bit of a nasty abstraction violation, but it
makes more sense overall. The only problem is that someone *might* be
using it - do we have any way to determine how, and how big do they
have to be before we care?
Paul
next prev parent reply other threads:[~2009-05-26 22:06 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-22 3:00 [PATCH] cgroups: handle failure of cgroup_populate_dir() at mount/remount Li Zefan
2009-05-22 8:25 ` KAMEZAWA Hiroyuki
2009-05-22 8:35 ` Li Zefan
2009-05-22 8:34 ` KAMEZAWA Hiroyuki
2009-05-22 9:10 ` Dhaval Giani
2009-05-25 9:14 ` Li Zefan
2009-05-25 9:47 ` Dhaval Giani
2009-05-26 22:06 ` Paul Menage [this message]
2009-05-27 1:07 ` Li Zefan
2009-05-27 1:34 ` KAMEZAWA Hiroyuki
2009-05-27 3:24 ` Li Zefan
2009-05-27 6:16 ` KAMEZAWA Hiroyuki
2009-05-25 13:17 ` Balbir Singh
2009-05-26 1:24 ` Li Zefan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6599ad830905261506x480f2167naf1034177bbc7036@mail.gmail.com \
--to=menage@google.com \
--cc=akpm@linux-foundation.org \
--cc=balbir@linux.vnet.ibm.com \
--cc=containers@lists.linux-foundation.org \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizf@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).