Re: [net-next PATCH v2 3/3] arm64: dts: qcom: ipq8074: add clock-frequency to MDIO node

Christian Marangi
2024-01-30T00:57:41Z

On Tue, Jan 30, 2024 at 01:55:28AM +0100, Andrew Lunn wrote:
> On Tue, Jan 30, 2024 at 01:35:22AM +0100, Christian Marangi wrote:
> > Add clock-frequency to MDIO node to set the MDC rate to 6.25Mhz instead
> > of using the default value of 390KHz from MDIO default divider.
> >
> > Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
> > ---
> > arch/arm64/boot/dts/qcom/ipq8074.dtsi | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/ipq8074.dtsi b/arch/arm64/boot/dts/qcom/ipq8074.dtsi
> > index 2f275c84e566..08ddfeece043 100644
> > --- a/arch/arm64/boot/dts/qcom/ipq8074.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/ipq8074.dtsi
> > @@ -264,6 +264,8 @@ mdio: mdio@90000 {
> > clocks = <&gcc GCC_MDIO_AHB_CLK>;
> > clock-names = "gcc_mdio_ahb_clk";
> >
> > + clock-frequency = <6250000>;
> > +
> > status = "disabled";
>
> If we merge this via netdev, is a merge conflict likely? Any other
> changes expected in this area, given the changes which might happen to
> GCC soon, etc?
>
> Reviewed-by: Andrew Lunn <andrew@lunn.ch>
>

Honestly I don't expect much to change here in the mdio node.

If it's a problem I can submit in a separate patch in linux-msm.

--
Ansuel