From: Christian Marangi <ansuelsmth@gmail.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Lee Jones <lee@kernel.org>, Pavel Machek <pavel@ucw.cz>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Heiner Kallweit <hkallweit1@gmail.com>,
Daniel Golle <daniel@makrotopia.org>,
Li Zetao <lizetao1@huawei.com>,
linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH] leds: trigger: netdev: Fix kernel panic on interface rename trig notify
Date: Mon, 5 Feb 2024 14:53:53 +0100 [thread overview]
Message-ID: <65c0e874.df0a0220.257a.43b1@mx.google.com> (raw)
In-Reply-To: <2cf84815-f9b6-4a0a-a3b4-d23628a89aa4@lunn.ch>
On Mon, Feb 05, 2024 at 02:41:46PM +0100, Andrew Lunn wrote:
> > > This should have 'net' in the subject line, to indicate which tree its
> > > for.
> >
> > No, it shouldn't.
> >
> > Contributors aren't obliged to know anything about merging strategies.
>
> With netdev, we tend to assume they do, or at least can contribute to
> the discussion. They often know about any dependencies etc which could
> influence the decision. When there are multiple subsystem maintainers
> involved, i tend to use To: to indicate the maintainer i think should
> merge the patch, and Cc: for the rest.
>
I'm always a bit confused when I have to send patch to mixed subsystem
(not the case but for net trigger it's almost that). Sorry for the
confusion/noise.
> > Why does this need to go in via net?
>
> It does not, as far as i'm aware. Christian, do you know of any
> reason?
>
This is strictly a fix, no dependency or anything like that. Maybe using
net as target would make this faster to merge (since net is for fix only
and this has to be backported) than using leds-next?
Again if needed I can send v2 with the correct tag for net subsystem if
better.
--
Ansuel
next prev parent reply other threads:[~2024-02-05 13:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-03 23:54 [PATCH] leds: trigger: netdev: Fix kernel panic on interface rename trig notify Christian Marangi
2024-02-04 15:15 ` Andrew Lunn
2024-02-05 8:50 ` Lee Jones
2024-02-05 13:41 ` Andrew Lunn
2024-02-05 13:53 ` Christian Marangi [this message]
2024-02-05 14:33 ` Lee Jones
2024-02-05 14:38 ` Christian Marangi
2024-02-05 15:04 ` Lee Jones
2024-02-08 14:12 ` Lee Jones
2024-02-05 14:27 ` Lee Jones
2024-02-08 14:04 ` (subset) " Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=65c0e874.df0a0220.257a.43b1@mx.google.com \
--to=ansuelsmth@gmail.com \
--cc=andrew@lunn.ch \
--cc=daniel@makrotopia.org \
--cc=davem@davemloft.net \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=lizetao1@huawei.com \
--cc=pavel@ucw.cz \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox