Re: [PATCH v1 12/31] x86/resctrl: Move max_{name,data}_width into resctrl code

Reinette Chatre
2024-04-11T17:38:27Z

Hi Dave,

On 4/11/2024 7:15 AM, Dave Martin wrote:
> On Mon, Apr 08, 2024 at 08:19:15PM -0700, Reinette Chatre wrote:
>> Hi James,
>>
>> On 3/21/2024 9:50 AM, James Morse wrote:
>>> @@ -2595,6 +2601,12 @@ static int schemata_list_add(struct rdt_resource *r, enum resctrl_conf_type type
>>> if (cl > max_name_width)
>>> max_name_width = cl;
>>>
>>> + /*
>>> + * Choose a width for the resource data based on the resource that has
>>> + * widest name and cbm.
>>
>> Please check series to ensure upper case is used for acronyms.
>
> [...]
>
>> Reinette
>
> This patch is just moving existing code around AFAICT. See:
> commit de016df88f23 ("x86/intel_rdt: Update schemata read to show data in tabular format")
>
> Since no new usage of any term is being introduced here, can it be
> left as-is?
>
> There seem to be other uses of "cbm" with this sense in the resctrl
> code already.

I am not asking to change all existing usages of these terms but in
any new changes, please use upper case for acronyms.

Reinette