Re: [PATCH v1 31/31] x86/resctrl: Move the resctrl filesystem code to /fs/resctrl

Fenghua Yu
2024-03-26T19:44:27Z

Hi, James,

On 3/21/24 09:51, James Morse wrote:
> resctrl is linux's defacto interface for managing cache and bandwidth
> policies for groups of tasks.
>
> To allow other architectures to make use of this pseudo filesystem,
> move it live in /fs/resctrl instead of /arch/x86.
>
> This move leaves behind the parts of resctrl that form the architecture
> interface for x86.
>
> Signed-off-by: James Morse <james.morse@arm.com>
> ---
> Discussion needed on how/when to merge this, as it would conflict with
> all outstanding series. It's probably worth deferring to some opportune
> time, but is included here for illustration.
> ---
> arch/x86/kernel/cpu/resctrl/core.c | 15 -
> arch/x86/kernel/cpu/resctrl/ctrlmondata.c | 505 ---
> arch/x86/kernel/cpu/resctrl/internal.h | 310 --
> arch/x86/kernel/cpu/resctrl/monitor.c | 821 -----
> arch/x86/kernel/cpu/resctrl/pseudo_lock.c | 1093 ------
> arch/x86/kernel/cpu/resctrl/rdtgroup.c | 3994 --------------------
> fs/resctrl/ctrlmondata.c | 527 +++
> fs/resctrl/internal.h | 340 ++
> fs/resctrl/monitor.c | 843 +++++
> fs/resctrl/psuedo_lock.c | 1122 ++++++
> fs/resctrl/rdtgroup.c | 4013 +++++++++++++++++++++
> 11 files changed, 6845 insertions(+), 6738 deletions(-)
>

checkpatch reports warnings and checks on this patch. Please fix them. e.g.

CHECK: Blank lines aren't necessary before a close brace '}'
#13340: FILE: fs/resctrl/rdtgroup.c:3184:
+
+ }

Thanks.

-Fenghua