Re: [PATCH v1 06/31] x86/resctrl: Export resctrl fs's init function

Dave Martin
2024-04-11T14:14:59Z

On Mon, Apr 08, 2024 at 08:16:32PM -0700, Reinette Chatre wrote:
> Hi James,
>
> On 3/21/2024 9:50 AM, James Morse wrote:
> > rdtgroup_init() needs exporting so that arch code can call it once
> > it lives in core code. As this is one of the few functions we export,
>
> Please do not impersonate code.

Noted. Any objection to rewording this as follows?

"As this is one of the few functions exported from the resctrl common code, [...]"

> > rename it to have the resctrl in the name. The same goes for the exit
>
> "to have the resctrl" -> "to have resctrl"

Noted for James' attention.

[...]

Cheers
---Dave